Add Docker AMD Support#1352
Conversation
Instructions on deploying to a swarm
Updated command for new swarm-AMDGPU-docker-compose.yml filename
Removed group "root" from swarmui user, it was redundant and less secure than the fix I already implemented (see "Set ROCm access" comment)
Removed it originally
Removed originally.
|
I think this could just be a couple comments/args on the existing scripts, and doesn't need to be whole new ones. Also get rid of the dockerswarm stuff 0.o |
|
Will make additional changes when I wake up, bedtime for me |
Added options to change between AMD and NVidia. Defaults to NVidia
|
How do you feel about my recent changes? To put it briefly: Added an extra commandline arg to launch-standard-docker.sh (You can now put "amd" or "nvidia" so long as fixch comes last) |
|
Oh, and the swarm images generated are called either swarmui-rocm or swarmui-nvidia. They have been implemented into the launch script properly |
|
Stop doing more things in one PR. Do the minimum necessary for the PR's intended purpose, which is AMD support for docker. Anything else can be a separate followup discussion. |
|
Sorry, I'm new to this whole github thing. Can you tell I'm an amateur? Lol |
|
Oh, you hand-merged the last fix commit instead of using a standard git merge, this prevents the PR from being merged. (If you're unfamiliar with git, you can also close and rebuild the PR if that's easier than fixing a git merge) |
I made a new swarm docker-compose.yml file, new StandardDockerfile.docker, and new ReadMe with instructions. I have only tested the distribution on a cluster of 1 computer, will test on more another time. This should improve scalability while adding AMD GPU support for those who want to run SwarmUI in Docker.