GitHub Actions CI workflow for iOS and Android#1435
Open
solodon4 wants to merge 12 commits intomicrosoft:masterfrom
Open
GitHub Actions CI workflow for iOS and Android#1435solodon4 wants to merge 12 commits intomicrosoft:masterfrom
solodon4 wants to merge 12 commits intomicrosoft:masterfrom
Conversation
…aries for cpprestsdk
…ts to current; Fixes wrong path to built boost.framework
…Updates version of upload artifact that is supposed to understand wildcards
…update link to the upstream repo
…d to be in this commit. Adding explanations to some cmake changes
Author
|
@BillyONeal, have you had a chance to look at this? |
Author
|
@BillyONeal, I've just updated this to build with the latest Boost-for-Android (only SHA change, needed because GitHub runners now use 21.3 NDK) and Apple-Boost-BuildScript (their script now builds the new .xcframework, which coincidentally simplifies our script). Please have a look to save me from the misery of maintaining a slew of cpprestsdk patches in my repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for GitHub Actions CI workflow for cpprestsdk on iOS and Android. GitHub Actions is free for open source repositories, so this should not cost anything, but lets us regularly validate mobile targets. Unlike Azure-Pipelines, GitHub Actions workflows get validated by forks, which allows contributors to see any problems before they send a pull request upstream. Binaries produced during the build are only published on tagged commits since they take about 345M for both platforms. Android build takes about 17 min and iOS build takes about 22 min.
This change updates commit SHAs of Boost-for-Android and Apple-Boost-BuildScript repos to latest ones as well as points back to the original Boost-for-Android repo, which now includes support for 21.1 NDK available on GitHub Actions runner, which the workaround does not yet support.
I had to change 2 cmake settings for iOS. One is related to a problem with some standard headers inclusion when targeting iOS that many developers seem to be facing, which I describe in greater details in this StackOveflow post. The other is a command-line warning that for some reason I was unable to disable the usual way via -Wno- flags.