You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Delete the unused .ado/scripts/build-hermesc-windows.js script.
The file was a Node.js port of the inline PowerShell logic in .github/workflows/build-hermesc-windows.yml (download ICU 64.2, copy MSVC runtime DLLs, configure with cmake -G "Visual Studio 17 2022" -Ax64, build the hermesc target, stage artifacts into win64-bin/). It appears to have been committed by accident — nothing ever called it:
No other workflow, CI task, build script, doc, or tool in the repo references build-hermesc-windows.js (verified via repo-wide grep).
The script's history is three small commits (Add build script → Update script → Make code compile for Windows) with no follow-up wiring.
The mainline Windows build flow remains .ado/scripts/build.js, which is unaffected by this change.
Test Plan
Verified via grep -r "build-hermesc-windows" that the only references in the repo are the workflow YAML (which inlines its own logic) and the deleted JS file itself.
No build, test, or CI path exercises this file, so no behavioral validation is needed — the change is a pure file deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete the unused
.ado/scripts/build-hermesc-windows.jsscript.The file was a Node.js port of the inline PowerShell logic in
.github/workflows/build-hermesc-windows.yml(download ICU 64.2, copy MSVC runtime DLLs, configure withcmake -G "Visual Studio 17 2022" -Ax64, build thehermesctarget, stage artifacts intowin64-bin/). It appears to have been committed by accident — nothing ever called it:build-hermesc-windows.js(verified via repo-wide grep).Add build script→Update script→Make code compile for Windows) with no follow-up wiring.The mainline Windows build flow remains .ado/scripts/build.js, which is unaffected by this change.
Test Plan
grep -r "build-hermesc-windows"that the only references in the repo are the workflow YAML (which inlines its own logic) and the deleted JS file itself.Microsoft Reviewers: Open in CodeFlow