Skip to content

Remove stale build script#312

Merged
vmoroz merged 1 commit intomicrosoft:mainfrom
vmoroz:PR/remove-stale-build-script
Apr 22, 2026
Merged

Remove stale build script#312
vmoroz merged 1 commit intomicrosoft:mainfrom
vmoroz:PR/remove-stale-build-script

Conversation

@vmoroz
Copy link
Copy Markdown
Member

@vmoroz vmoroz commented Apr 21, 2026

Summary

Delete the unused .ado/scripts/build-hermesc-windows.js script.

The file was a Node.js port of the inline PowerShell logic in .github/workflows/build-hermesc-windows.yml (download ICU 64.2, copy MSVC runtime DLLs, configure with cmake -G "Visual Studio 17 2022" -Ax64, build the hermesc target, stage artifacts into win64-bin/). It appears to have been committed by accident — nothing ever called it:

  • The matching workflow at .github/workflows/build-hermesc-windows.yml inlines the same PowerShell directly rather than invoking the script.
  • No other workflow, CI task, build script, doc, or tool in the repo references build-hermesc-windows.js (verified via repo-wide grep).
  • The script's history is three small commits (Add build scriptUpdate scriptMake code compile for Windows) with no follow-up wiring.

The mainline Windows build flow remains .ado/scripts/build.js, which is unaffected by this change.

Test Plan

  • Verified via grep -r "build-hermesc-windows" that the only references in the repo are the workflow YAML (which inlines its own logic) and the deleted JS file itself.
  • No build, test, or CI path exercises this file, so no behavioral validation is needed — the change is a pure file deletion.
Microsoft Reviewers: Open in CodeFlow

@vmoroz vmoroz requested a review from a team as a code owner April 21, 2026 23:21
@vmoroz vmoroz force-pushed the PR/remove-stale-build-script branch from fb5da83 to af65342 Compare April 21, 2026 23:22
@vmoroz vmoroz enabled auto-merge (squash) April 21, 2026 23:54
@github-actions
Copy link
Copy Markdown

Benchmark Results

Total benchmarks: 102

v8

Benchmark (ms) hermes (CI)
v8-crypto 604.6
v8-deltablue 752.2
v8-raytrace 128.8
v8-regexp 593
v8-richards 936.8
v8-splay 232.6

test-suites

Benchmark (ms) hermes (CI)
box2d 3044
earley-boyer 3041.2
navier-stokes 6257
pdfjs 1022
gbemu 2297.2
code-load 6958.6
typescript 3419.2
simpleSum 9019.8
propAccess 2749.6
allocObj 255.4
allocObjLit 6479.4
allocNewObj 20819.6
allocArray 251
allocNewArray 34971.8
arrayRead 120.4
arrayReadByIndex 576.8
largeArrayRead 794.4
arrayWrite 253
largeArrayWrite 2160.8
interp-dispatch 2956.8
wb-perf 8224
arrayReverse 40.6
arrayMap 1441.6
arrayIndexOf 144.2
arrayLastIndexOf 156.6
arrayEvery 2172.4
arraySome 2184.2
arrayFill 2372.4
arrayFilter 1823.6
arrayFind 3196.6
arrayFindIndex 3215.4
arrayPop 1030.8
arrayReduce 1995.8
arrayReduceRight 1992.2
arrayShift 2049
arrayUnshift 2081.2
arrayIncludes 1216.8
arrayFrom 1113.4
arrayCopyWithin 1489.6
stringFromCharCode 93.8
arraySlice 793.2
arraySplice 26.8
arrayOf 1055.2
stringCharAt 1266.6
stringMatch 2858.6
stringSearch 2847.2
stringStartsWith 594
stringEndsWith 538.4
stringIncludes 1479
stringIndexOf 1483.6
stringLastIndexOf 1742.8
stringSplit 804.2
stringSlice 485.8
stringPadStart 2907.2
stringPadEnd 2905.8
regExpMatch 1497.6
regExpSearch 1219.8
regExpToString 1199.8
stringReplace 1362.2
regExpReplace 862.4
regExpFlags 925.4
regExpSplit 1322.2
numberArrayReadWrite 2399
protoCache 3535

micros

Benchmark (ms) hermes (CI)
micros/getNodeById.js 5011
micros/setInsert.js 2601
micros/stringify-number.js 1813.6
micros/typed-array-sort.js 22359.4

jit-benches

Benchmark (ms) hermes (CI)
jit-benches/idisp.js 2914.8
jit-benches/idispn.js 3379.6

many-subclasses

Benchmark (ms) hermes (CI)
many-subclasses/many.js 19179.2
many-subclasses/many-sh-1.js 7749.4
many-subclasses/many-sh-2.js 7543.8
many-subclasses/many-sh-3.js 7127.8
many-subclasses/many-sh-4.js 7131.8

map-objects

Benchmark (ms) hermes (CI)
map-objects/map-objects-untyped.js 1015.6
map-objects/map-objects-typed.js 954.8

map-strings

Benchmark (ms) hermes (CI)
map-strings/map-strings-untyped.js 1186.8
map-strings/map-strings-typed.js 1140

nbody

Benchmark (ms) hermes (CI)
nbody/original/nbody.js 846.4
nbody/fully-typed/nbody.js 707
nbody/fully-typed/nbody.ts 841.6

string-switch

Benchmark (ms) hermes (CI)
string-switch/plain/bench.js 1310.8

raytracer

Benchmark (ms) hermes (CI)
raytracer/original/bench-raytracer.js 1550.8
raytracer/original/raytracer.ts 1667.8

MiniReact

Benchmark (ms) hermes (CI)
MiniReact/no-objects/out/simple-stripped.js 2233.6
MiniReact/no-objects/out/simple-lowered.js 2258.4
MiniReact/no-objects/out/music-stripped.js 40.8
MiniReact/no-objects/out/music-lowered.js 46.2
MiniReact/no-deps/stripped/MiniReact.js 5109.8
MiniReact/no-deps/MiniReact.js 5074.2
MiniReact/no-objects/out/simple.js 2227.8
MiniReact/no-objects/out/music.js 44.2

widgets

Benchmark (ms) hermes (CI)
widgets/simple-classes/widgets.js 1750.6
widgets/original/es5/widgets.js 2759
widgets/single-file/es5/widgets.js 2757.4

@vmoroz vmoroz merged commit 2533529 into microsoft:main Apr 22, 2026
14 checks passed
@vmoroz vmoroz deleted the PR/remove-stale-build-script branch April 22, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants