fix: add InputFocusedContext guard to notebook output Escape keybinding#308695
Open
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add InputFocusedContext guard to notebook output Escape keybinding#308695yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The Escape keybinding for 'Stop Editing Cell' when notebook output is focused was missing an InputFocusedContext.toNegated() guard. This caused the keybinding to incorrectly fire when a user pressed Escape to dismiss autocomplete suggestions while editing a cell, because the NOTEBOOK_OUTPUT_FOCUSED context key could remain stale from a previous output focus. Adding the InputFocusedContext.toNegated() condition ensures this keybinding only triggers when no input element has focus, preventing it from interfering with editor input actions like dismissing completions. Fixes microsoft#234235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #234235
The
Escapekeybinding for "Notebook: Stop Editing Cell" when notebook output is focused (notebookEditorFocused && notebookOutputFocused) was missing anInputFocusedContext.toNegated()guard. This caused the keybinding to incorrectly fire when a user pressedEscapeto dismiss autocomplete suggestions while editing a cell, because theNOTEBOOK_OUTPUT_FOCUSEDcontext key could remain stale from a previous output focus.InputFocusedContext.toNegated()to the output-focusedEscapekeybinding'swhenconditionTest plan
Escapeto dismiss the popupEscape