Open
Conversation
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses tool approval management UX by allowing combination-level approvals to carry a displayable arguments string, so users can distinguish and manage specific “tool + args” approvals (e.g., different extension.open invocations).
Changes:
- Changes the proposed
approveCombinationshape to include a{ message, arguments? }object so tools can provide a user-visible argument summary. - Persists the combination “arguments” string alongside the combination approval key and surfaces it in the Manage Tool Approvals quick tree via a “View Arguments” button/dialog.
- Updates Copilot’s VS Code command tool to populate the new
approveCombination.argumentsfield and display args in the confirmation message.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.toolInvocationApproveCombination.d.ts | Updates proposed API type/docs for combination approval metadata (message + arguments). |
| src/vs/workbench/contrib/chat/common/tools/languageModelToolsService.ts | Extends internal tool confirmation message shape to carry arguments for combinations. |
| src/vs/workbench/contrib/chat/common/tools/languageModelToolsConfirmationService.ts | Extends confirmation ref/combination type to include arguments. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolConfirmationSubPart.ts | Passes combination arguments through UI confirmation subpart plumbing. |
| src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts | Stores/loads combination args; adds “View Arguments” UI affordance and dialog. |
| src/vs/workbench/api/common/extHostLanguageModelTools.ts | Converts new proposed API shape into internal { label, key, arguments } confirmation data. |
| extensions/copilot/src/extension/vscode.proposed.toolInvocationApproveCombination.d.ts | Mirrors the proposed API change in the Copilot extension’s proposal typings. |
| extensions/copilot/src/extension/tools/node/vscodeCmdTool.tsx | Populates and displays command arguments; emits new approveCombination object. |
| .github/instructions/api-version.instructions.md | Updates contributor guidance around proposed API versioning/back-compat. |
Copilot's findings
- Files reviewed: 7/9 changed files
- Comments generated: 4
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts
Show resolved
Hide resolved
lszomoru
previously approved these changes
Apr 9, 2026
lszomoru
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306264