fix(scm): use proper default label foreground for history item#308802
Open
hecticme wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(scm): use proper default label foreground for history item#308802hecticme wants to merge 1 commit intomicrosoft:mainfrom
hecticme wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes SCM Graph history badge label theming by using the dedicated scmGraph.historyItemHoverDefaultLabelForeground color as the fallback foreground for uncolored history item badges, aligning the graph badge appearance with the hover dialog.
Changes:
- Switch badge label fallback foreground from global
foregroundtohistoryItemHoverDefaultLabelForeground. - Update imports accordingly in the history view pane renderer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #308796
Use
historyItemHoverDefaultLabelForegroundinstead offoregroundas the fallback foreground color of history item badge.A theme that has
historyItemHoverDefaultLabelForegroundwill now use same color in the graph compared to the hover dialog.Please take a look at the yellow badge on the left panel:
This setting now does what its name suggests:
{ "workbench.colorCustomizations": { "scmGraph.historyItemHoverDefaultLabelForeground": "#000000", // "foreground": "#000000", // No longer has an effect on badge label. } }