Preparations for v1.43.1 release#948
Merged
michelebastione merged 3 commits intomini-software:v1.x-maintenancefrom Apr 19, 2026
Merged
Preparations for v1.43.1 release#948michelebastione merged 3 commits intomini-software:v1.x-maintenancefrom
michelebastione merged 3 commits intomini-software:v1.x-maintenancefrom
Conversation
In preparation for the next release, the project file has been cleaned up a little and the benchmark.yml workflow file has been revised.
This makes the v1.x branch less cluttered and more mantainable. Also the purposeless MiniEcel.Code.cs file has been deleted.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a large-scale refactoring of the library, including the adoption of file-scoped namespaces, updated target frameworks in the project file, and general code cleanup across the CSV and OpenXml modules. The review feedback points out a logic error in the dimension calculation for sheets without cell references, which leads to inconsistent indexing between 0-based and 1-based counts. Additionally, performance improvements are suggested for data querying by replacing inefficient array searches with direct dictionary lookups and optimizing byte array population from streams to avoid redundant memory stream allocations.
michelebastione
merged commit ce7bb90
into
mini-software:v1.x-maintenance
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes applied
1.43.1benchmark.ymlfileMiniExcelLibs.csprojfile, setImplicitUsingsproperty to true and increasedLangVersionproperty to 14MiniExcel.Code.csfileThe high number of diffs is simply due to the conversion of all files to file-scoped namespaces.