Skip to content

code_challenge_method checks.#1393

Open
srmoore wants to merge 4 commits intomitreid-connect:masterfrom
srmoore:pkce-code-challenge-method-match-client-defined-method
Open

code_challenge_method checks.#1393
srmoore wants to merge 4 commits intomitreid-connect:masterfrom
srmoore:pkce-code-challenge-method-match-client-defined-method

Conversation

@srmoore
Copy link
Copy Markdown
Member

@srmoore srmoore commented May 21, 2018

Added in a check to make sure the code_challenge_method matches what is defined in the client.

@srmoore srmoore requested a review from jricher May 21, 2018 22:25
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 21, 2018

Codecov Report

Merging #1393 into master will increase coverage by 0.1%.
The diff coverage is 9.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1393     +/-   ##
===========================================
+ Coverage     25.21%   25.32%   +0.1%     
- Complexity      912      919      +7     
===========================================
  Files           209      209             
  Lines         11689    11710     +21     
  Branches       2116     2123      +7     
===========================================
+ Hits           2947     2965     +18     
- Misses         8227     8229      +2     
- Partials        515      516      +1
Impacted Files Coverage Δ Complexity Δ
...token/ScopeServiceAwareOAuth2RequestValidator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ce/impl/DefaultOAuth2AuthorizationCodeService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ervice/impl/DefaultOAuth2ProviderTokenService.java 60.89% <66.66%> (+9.18%) 33 <0> (+7) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802e40e...7194b38. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants