feat(app): render NAIS env var and file sources distinctly#712
Merged
Conversation
nais-api now distinguishes user-defined SPEC values from platform- injected NAIS values (see nais/api#402). Render NAIS-sourced entries as 'Nais/<name>' while keeping SPEC rendering unchanged. Rename 'ConfigMaps' to 'Configs' in 'nais app files' help text for consistency with the user-facing 'Config/<name>' rendering. Also fix the schema update tasks to use the promoted top-level 'api' command (was 'alpha api') so 'mise run update:graphql-schema:{live,local}' works again after the command promotion.
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v5.26.0 - 2026-04-17Full Changelog: v5.25.7...v5.26.0 🚀 Features
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the new
NAISvalue inInstanceGroupValueSourceKind(nais/api #402) so the CLI can distinguish values sourced from the Nais platform from those defined in the application manifest.Changes
Initiative-related
internal/app/envvars.go: renderNAISsources asNais/<name>(SPEC rendering unchanged)internal/app/command/files.go: user-facing help text "Secrets and ConfigMaps" → "Secrets and Configs"Schema regeneration (mandated by AGENTS.md after API schema changes)
schema.graphql+internal/naisapi/gql/generated.go: regenerated viamise run update:graphql-schema:live. In addition to theNAISsource kind, this picks up unrelated schema evolution that has landed in nais/api since the last regeneration:ApplicationRestartLoopIssue/APPLICATION_RESTART_LOOP,PostgresDeletedActivityLogEntry/POSTGRES_DELETED,deletePostgresmutation,lastExitTimestamponApplicationInstance. These are not consumed by any code in this PR — they're just along for the ride because the file mirrors the live API.Bonus fix
mise/tasks/update/graphql-schema/{live,local}.sh:nais alpha api→nais api(thealphanamespace was removed in bcbae80; the scripts were broken before this PR)Verification
mise run fmt✅go build ./...✅go test ./...✅