Add smell for limitting the number of explicit imports#1677
Open
crtschin wants to merge 2 commits intondmitchell:masterfrom
Open
Add smell for limitting the number of explicit imports#1677crtschin wants to merge 2 commits intondmitchell:masterfrom
crtschin wants to merge 2 commits intondmitchell:masterfrom
Conversation
|
This is especially helpful to contain the number of explicit imports in the codebase where a portion of people use HLS, since HLS by default uses explicit import lists, but lots of explicit imports make the codebase incredibly hard/tedious to modify for people who don't use HLS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1676.
Does what it says on the tin. Adds a new smell called
many explicit importsthat the user can use to limit the number of explicit imports. Extended both inline (I think that's what these are) and golden tests to include this setting.