Skip to content

edit tags#16672

Open
tobiasKaminsky wants to merge 4 commits intomasterfrom
editTags
Open

edit tags#16672
tobiasKaminsky wants to merge 4 commits intomasterfrom
editTags

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky commented Mar 13, 2026

Disclaimer: Claude AI

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16672.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

alperozturk96
alperozturk96 requested changes Mar 18, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/adapter/TagListAdapter.kt
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagListAdapter.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt Outdated
Comment thread app/src/main/java/com/nextcloud/ui/tags/TagManagementViewModel.kt
val nextcloudClient = clientFactory.createNextcloudClient(currentAccountProvider.user)
val createResult = CreateTagRemoteOperation(name).execute(nextcloudClient)

if (createResult.isSuccess) {
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply fail fast princible instead of nested ifs.

Comment thread app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
.show(fragmentManager, "actions");
}

private void refreshTagChips(Context context) {
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileDetailFragment already 900+ lines of code. Let's not make it more harder to maintain. Please create a new Kotlin class and pass reference and handle the refresh tag chips there.

@mpivchev mpivchev mentioned this pull request Mar 24, 2026
Open
@tobiasKaminsky
edit tags
115f67b 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
wip
8a57446 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
wip
bf31347 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24389201000/artifacts/6423672148
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky
create TagUiState
f3e4f09 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6969
Dodgy code227227
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total433433

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24439364984/artifacts/6444218935
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasKaminsky @alperozturk96