Fix horizontal grid jumping on lazy load in Vue VirtualList#59549
Open
RicoUHD wants to merge 4 commits intonextcloud:masterfrom
Open
Fix horizontal grid jumping on lazy load in Vue VirtualList#59549RicoUHD wants to merge 4 commits intonextcloud:masterfrom
RicoUHD wants to merge 4 commits intonextcloud:masterfrom
Conversation
The virtual list calculation of column counts used to be out of sync with CSS grid in the case where browser scrollbars have inconsistent layouts. This was because `auto-fill` includes scrollbar dimensions, while JS mathematically excluded them relying on the outer container. By syncing the inner width (clientWidth) without scrollbars in the ResizeObserver and dynamically pushing the calculated columnCount to inline style gridTemplateColumns on the container, the Javascript rendering completely matches the CSS layout engine rendering. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…78234 Fix grid view jumping horizontally on lazy load
Signed-off-by: Enrico Lehn <enrico.lehn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a visual bug in the Nextcloud Files app where the Grid view shifts left horizontally by one icon position whenever a user scrolls down and lazy-loads a new row of items.
The fix updates
VirtualList.vueto base grid calculations explicitly on theinner clientWidthtracking the inner body, which forces the exact matched template columns in the DOM and prevents the grid from jumping.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)