Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
15aff59 to
9b4afdb
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
9b4afdb to
d43a2a7
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
d43a2a7 to
f52166a
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
7 times, most recently
from
6637691 to
e746625
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
5 times, most recently
from
6d4c06b to
1ade042
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
4 times, most recently
from
853ca71 to
0a18ad3
Compare
Merged
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
0a18ad3 to
d1d57d9
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
d1d57d9 to
f8e013c
Compare
Member
Turns out this already happens and we don't have to change anything: |
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
f8e013c to
b9d99f2
Compare
Signed-off-by: Max <max@nextcloud.com>
Otherwise the old session would get mixed with the new content when people come back with old state in indexed-db. ( Run playwright/e2e/indexed-db.spec.ts for an example. ) Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
This could be the basis for automatically merging changes from an offline editing session and changes by overwriting the doc. Signed-off-by: Max <max@nextcloud.com>
Reconnect to a new session but remember the local change. Show a conflict between the remote session and the local change. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Conflicts with unsaved changes in indexed db work differently. When the file is overwritten on the server while editing the editing session keeps going and the new file version is shown read only. When opening the file and a conflicting version is found in indexed db that local version is shown read only allowing to connect to a new session. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Broadcast is disabled right now. Make sure two editing sessions for the same file to not mix when enabling it. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
The pushing does not happen yet - thus the test is failing. Signed-off-by: Max <max@nextcloud.com>
Expose the update mechanism inside the websocket provider. This is normally triggered by updates of the ydoc. But as the updates happened while offline in a previous session we need to trigger it explicitely. The websocket provider holds the remote state of the document. So it can compute an update based on this and the current ydoc. Signed-off-by: Max <max@nextcloud.com>
…ode) Signed-off-by: silver <s.szmajduch@posteo.de>
… (ai code) Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
mejo-
reviewed
Apr 21, 2026
| }) | ||
| }) | ||
| .catch((err) => { | ||
| logger.warn('IndexedDB sync did not complete', { err }) |
Member
There was a problem hiding this comment.
Do we know in which scenarios this throws? I wonder whether this should be handled gracefully or whether this is a scenario that actually should throw as something is broken afterwards.
There might still be dangling async functions trying to write to IndexedDB after `clearIndexedDB()` was called. Guard against these race conditions. Generated with the help of AI but verified and implemented manually. Signed-off-by: Jonas <jonas@freesources.org>
Needed so local changes don't get lost when editor is closed in case of conflict. Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs
base_version_etagas custom property to IndexedDBbaseVersionEtagas part of create requestbaseVersionEtag.