Fix .my_name resolution and add source(self) annotation for beliefs#21
Open
mrebollo wants to merge 3 commits intoniklasf:masterfrom
Open
Fix .my_name resolution and add source(self) annotation for beliefs#21mrebollo wants to merge 3 commits intoniklasf:masterfrom
mrebollo wants to merge 3 commits intoniklasf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
.my_nameresolution inagentspeak/stdlib.py, addssource(self)annotations for beliefs created without an explicit source inagentspeak/runtime.py, and enables the counting example for runtime validation.Changes
.my_nameunification to usestr(agent.name)instead ofLiteral(agent.name).source(self)automatically when a belief is inserted without an existingsource(...)annotation..my_nameusage inexamples/counting/counting.aslso the example prints the agent name at the end of counting.Why
These changes improve consistency in two areas:
.my_nameshould unify with a plain string value.source(self)so their origin is explicit and consistent with message-based beliefs.Validation
Validated locally by running:
pytest -q tests/test_stdlib.py tests/test_terms.py tests/test_parser.pypython -m agentspeak examples/counting/counting.aslThe test suite passed, and the counting example printed the resolved agent name correctly.
Scope
This PR is limited to
python-agentspeakchanges related to:.my_nameresolutionsource(self)annotation for beliefsexamples/counting/counting.asl