[ADD] estate: created estate module #1225
Draft
vivah-odoo wants to merge 18 commits intoodoo:19.0from
Draft
Conversation
- Added estate.property model - Implemented core fields (name, description, expected_price, etc.) - Applied required field constraints - Enabled ORM-based persistence Chapter 3
|
|
Clean up code and module metadata: - Remove trailing newline and blank line whitespace (W391, W293) - Add missing `author` and `license` in __manifest__.py This removes lint and module loading warnings.
vivah-odoo
changed the title
- Added ir.model.access.csv for estate.property - Configured basic CRUD permissions for internal users Chapter 4 - Security Intro
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
d2d43cc to
d6c591c
Compare
- Fixed COM819 lint error in __manifest__.py - Removed/adjusted trailing comma in data list for proper formatting
vivah-odoo
changed the title
- Define window action and menu structure to expose estate.property in the UI. - Connect menus with the action to allow access to list and form views. - Register XML view and menu files in the manifest for proper loading. - Configure default values using Odoo framework utilities. - Apply field attributes like readonly and copy=False for better data control. - Add active flag for visibility handling and state field for lifecycle management. Chapter-5
mash-odoo
requested changes
Apr 9, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Thank you for your work.
Here are some few questions and suggestions.
Also please update your PR title
vivah-odoo
changed the title
vivah-odoo
changed the title
Apply changes based on PR review comments. - Refactored code to follow Odoo coding guidelines - Fixed linting and formatting issues - Improved model field definitions where required - Removed redundant or unnecessary code
Added list view for estate.property model. - Defined list view in estate_property_views.xml using <list> tag - Configured fields to be displayed in the list view - Added string attributes to model fields for proper labeling Chapter 6
- Added search view with: - Searchable fields (name, postcode, price, state, etc.) - Custom filters (1 Bedroom & Garage, budget, availability, expensive) - Group by options (bedrooms, garage, availability date) - UI improvements using separators - Configured action with default filter for available properties Completed Chapter 6
- Add Many2one fields: property_type_id, salesperson_id, buyer_id, and partner_id on offer - Add One2many field offer_ids on estate.property - Add Many2many field tag_ids on estate.property - Update form and list views to display relational fields chapter 7
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
ded3d2d to
4a2a54c
Compare
Fixed whitespace issue in the file 'estate_properties_type.py'
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
ad0b026 to
223e8e2
Compare
This commit introduces two computed fields on estate.property: - total_area: calculated as the sum of living_area and garden_area. - best_price: stores the highest offer price among related offers. Chapter 8 partially completed
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
223e8e2 to
d364336
Compare
- Added `validity` field with default value of 7 days. - Added computed `date_deadline` field based on `create_date` and `validity`. - Implemented inverse method to allow editing either validity or deadline. - Added fallback for `create_date` during record creation to avoid errors. - Updated form and list views to display new fields. chapter 8 partially completed
vivah-odoo
force-pushed
the
19.0-tutorial-vivah
branch
from
d364336 to
7f55d54
Compare
This commit introduces an onchange method on the `garden` field to improve user experience during data entry: * Automatically sets `garden_area` to 10 and `orientation` to 'North' when garden is enabled. * Resets `garden_area` to 0 and clears `orientation` when disabled. Chapter 8 completed
- Add 'Cancel' and 'Sold' buttons on estate.property - Prevent invalid state transitions (cancelled ↔ sold) - Add 'Accept' and 'Refuse' buttons on estate.property.offer - Set buyer and selling price when an offer is accepted - Ensure only one offer can be accepted per property - Raise UserError for invalid operations chapter 9
mash-odoo
requested changes
Apr 23, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello,
Good going on the task..
Here are some questions and suggestions...
- Use ensure_one() and simplify action_accept logic - Remove redundant field strings - Clean XML views (no fixed width, simpler structure, newline fix) - Use editable tree instead of single-field form view - Optimize domain filters
- Enforced positive expected price on properties - Ensured selling price is positive - Restricted offer price to strictly positive values - Added unique constraints on property type and tag names chapter 10
- Added @api.constrains on selling_price and expected_price - Enforced rule: selling price must be at least 90% of expected price - Used float_compare and float_is_zero for safe float handling - Ignored validation when selling price is zero (no accepted offer yet) - Ensured constraint triggers on both create and write operations chapter 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chapter-5