dalio - Technical Training by dalio-odoo · Pull Request #1233 · odoo/tutorials

dalio-odoo · 2026-04-21T12:00:52Z

No description provided.

robodoo · 2026-04-21T12:00:55Z

Mathilde411

Very solid PR.
Also be careful of usage of ' vs ". You should use a convention and stick to it.
Most R&D teams use ' :)

Mathilde411 · 2026-04-22T12:43:57Z

+{
+    "python.analysis.extraPaths": [
+        "/home/odoo/src/venv",
+        "/home/odoo/src/odoo",
+        "/home/odoo/src/enterprise"
+    ],
+    "python.defaultInterpreterPath": "/home/odoo/src/venv/bin/python3.12"
+}


This file is your local vscode confing, you shouldn't commit and push it to the repo

Mathilde411 · 2026-04-22T12:45:54Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink


Using slashes work, but most commonly used is:

Suggested change

id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink

id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink

Mathilde411 · 2026-04-22T12:47:58Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1


The access right should say what group it applies on.
Name is meant to be displayed, usually names use dots in Odoo

Suggested change

access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

estate_property_access_user,estate.property.user,model_estate_property,base.group_user,1,1,1,1

Mathilde411 · 2026-04-22T12:50:32Z

+    <menuitem id="estate_menu_root" name="Real Estate"/>
+        <menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>
+            <menuitem id="estate_property_menu_action" parent="estate_first_level_menu" action="estate_property_action"/>


Menu items can be nested, avoids having to set the parent

Suggested change

<menuitem id="estate_menu_root" name="Real Estate"/>

<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>

<menuitem id="estate_property_menu_action" parent="estate_first_level_menu" action="estate_property_action"/>

<menuitem id="estate_menu_root" name="Real Estate">

<menuitem id="estate_first_level_menu" name="Advertisements">

<menuitem id="estate_property_menu_action" action="estate_property_action"/>

</menuitem>

</menuitem>

Mathilde411 · 2026-04-22T12:53:03Z

+    <menuitem id="estate_menu_root" name="Real Estate"/>
+        <menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>
+            <menuitem id="estate_property_menu_action" parent="estate_first_level_menu" action="estate_property_action"/>


https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

Suggested change

<menuitem id="estate_menu_root" name="Real Estate"/>

<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>

<menuitem id="estate_property_menu_action" parent="estate_first_level_menu" action="estate_property_action"/>

<menuitem id="estate_menu_root" name="Real Estate"/>

<menuitem id="estate_menu_advertisement" name="Advertisements" parent="estate_menu_root"/>

<menuitem id="estate_property_menu" parent="estate_menu_advertisement" action="estate_property_action"/>

Mathilde411 · 2026-04-22T12:54:16Z

@@ -0,0 +1,15 @@
+{
+    'name': 'Real Estate',
+    'version': '1.0',


When using modules outside odoo standard, best practice is to specify th Odoo version.

Suggested change

'version': '1.0',

'version': '19.0.1.0.0',

Mathilde411 · 2026-04-22T12:55:07Z

+    'name': 'Real Estate',
+    'version': '1.0',
+    'depends': [
+        'base_setup'


For the diff if you add a new dependency

Suggested change

'base_setup'

'base',

Also you should depend on base not base_setup

Mathilde411 · 2026-04-22T12:55:20Z

+    'data': [
+        'security/ir.model.access.csv',
+        'views/estate_property_views.xml',
+        'views/estate_menus.xml'


Same, add a comma for the diff

Mathilde411

Very good, I don't have a lot to say :D

Mathilde411 · 2026-04-24T09:08:55Z

@@ -0,0 +1 @@
+from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer


Make it one line per import, this way you can see what commit adds whant, and resolving conflicts is easier :)

Mathilde411 · 2026-04-24T09:12:43Z

+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)",
+        "the expected price must be strictly positive.",
+    )
+
+    _check_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)",
+        "the selling price must be positive.",
+    )
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for record in self:
+
+            if float_is_zero(record.selling_price, precision_digits=2):
+                continue
+
+            lower_bound = 0.9 * record.expected_price
+
+            if float_compare(record.selling_price, lower_bound, precision_digits=2) == -1:
+                raise ValidationError(
+                    "The selling price must be at least 90% of the expected price! "
+                    "You must reduce the expected price if you want to accept this offer."
+                )


Be careful about attribute ordering

Mathilde411 · 2026-04-24T09:14:43Z

+    )
+    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
+    salesman_id = fields.Many2one("res.users", string="Salesman", default=lambda self: self.env.user)
+    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)


When using a many2one the string is inferred by removing _id at the end. So buyer_id default string is "Buyer", so no need to add the string there :D
(same for many2many and one2many but w/ _ids instead)

Mathilde411 · 2026-04-24T09:16:15Z

+            prices = record.offer_ids.mapped("price")
+
+            if prices:
+                record.best_price = max(prices)
+            else:
+                record.best_price = 0.0


Suggested change

prices = record.offer_ids.mapped("price")

if prices:

record.best_price = max(prices)

else:

record.best_price = 0.0

prices = max(record.offer_ids.mapped("price"), default=0.0)

There is a default argument on max (and min) that avoids the condition

Mathilde411 · 2026-04-24T09:18:57Z

+    def _compute_date_deadline(self):
+        for record in self:
+            base_date = record.create_date or fields.Date.today()
+            days_to_add = record.validity or 0


You don't need the days_to_add here, for numeric fields, the default value is always 0, so you can use record.validity directly :)

Mathilde411 · 2026-04-24T09:21:14Z

+
+    def _inverse_date_deadline(self):
+        for record in self:
+            base_date = fields.Date.to_date(record.create_date) or fields.Date.today()


use 'record.create_date.date()'

Mathilde411 · 2026-04-24T09:22:52Z

+        for record in self:
+            record.status = "refused"


Suggested change

for record in self:

record.status = "refused"

self.status = "refused"

You can assign values of recordsets attributes, no need to iterate :D

Mathilde411 · 2026-04-24T09:24:26Z

+                    <button name="action_sold" 
+                            string="Sold" 
+                            type="object" 
+                            class="oe_highlight"/> <button name="action_cancel" 
+                            string="Cancel" 
+                            type="object"/> <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/>


Formatting is weird here

Mathilde411 · 2026-04-24T09:25:05Z

+                    </div>
+                    <group>
+                        <group>
+                            <field name="state"/>


State here is not necessary since you have the statusbar :)

This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.

[REF] Internal: test setup dalio

3c4ec5c

Mathilde411 self-requested a review April 21, 2026 13:30

dalio-odoo added 4 commits April 22, 2026 10:58

[ADD] estate: add model

46f010c

[ADD] estate: add estate_property

2a943c1

[FIX] estate: fix style

25b1b95

[ADD] estate: add access right for estate_property

d9454fb

dalio-odoo force-pushed the 19.0-technical-training-dalio branch from 6d29bbd to d9454fb Compare April 22, 2026 09:00

dalio-odoo added 2 commits April 22, 2026 11:19

[FIX] estate: add author and license to manifest

c767015

[ADD] estate: add menus, actions and property fields logic

4faa6cd

Mathilde411 requested changes Apr 22, 2026

View reviewed changes

dalio-odoo added 6 commits April 22, 2026 16:42

[IMP] estate: add search features and apply style and security fixes

c626a8c

[ADD] estate: add types and tags

f0442fb

[ADD] estate: add offers to properties

4ac7f31

[ADD] estate: add computed fields and onchanges

3bd3578

[ADD] estate: add 'Sold' and 'Canceled' buttons

7061f54

[ADD] estate: add business logic with buttons and constraints

a3ebbc7

Mathilde411 requested changes Apr 24, 2026

View reviewed changes

Mathilde411 and others added 7 commits April 24, 2026 11:43

[IMP] estate: Change prices to monetary fields.

ae62f85

[IMP] estate: improve property type view and refactor code standards

eac8447

[IMP] estate: improve syntax

66a69db

[IMP] estate: improve syntax

3b213a0

[IMP] estate: improve syntax

56e45d3

[IMP] estate: improve syntax

da5403d

[IMP] estate: improve UI with editable lists and stat buttons

1338c5c

dalio-odoo force-pushed the 19.0-technical-training-dalio branch from 2409a9d to 1338c5c Compare April 27, 2026 14:05

dalio-odoo added 4 commits April 27, 2026 16:13

[FIX] estate: add readonly to invisible status field in offer list

95e7a49

[FIX] estate: remove redundant invisible field

83b110c

[ADD] estate: add business logic for offers and extend user view

b32aada

[ADD] estate_account: automate invoices creation on sold properties

98017ce

vandroogenbd and others added 5 commits April 28, 2026 15:39

[IMP] estate_account: improve syntax

b214019

[FIX] estate: add missing garden information in test

1a1486f

[ADD] estate: add grouped kanban view for properties

1dff51c

[FIX] estate: fix business logic to ensure all tests are passed

5b2c1b2

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink

	id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
	id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

	access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1
	estate_property_access_user,estate.property.user,model_estate_property,base.group_user,1,1,1,1

-    <menuitem id="estate_menu_root" name="Real Estate"/>
-        <menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>
-            <menuitem id="estate_property_menu_action" parent="estate_first_level_menu" action="estate_property_action"/>
+    <menuitem id="estate_menu_root" name="Real Estate">
+        <menuitem id="estate_first_level_menu" name="Advertisements">
+            <menuitem id="estate_property_menu_action" action="estate_property_action"/>
+        </menuitem>
+    </menuitem>

		@@ -0,0 +1 @@
		from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer

	for record in self:
	record.status = "refused"
	self.status = "refused"

Conversation

dalio-odoo commented Apr 21, 2026

Uh oh!

robodoo commented Apr 21, 2026

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants