Skip to content

sever - Technical Training#1235

Open
SebVrc wants to merge 19 commits intoodoo:19.0from
odoo-dev:19.0-tutorials-sever
Open

sever - Technical Training#1235
SebVrc wants to merge 19 commits intoodoo:19.0from
odoo-dev:19.0-tutorials-sever

Conversation

@SebVrc
Copy link
Copy Markdown

@SebVrc SebVrc commented Apr 21, 2026

Pull request for the tutorials

@robodoo
Copy link
Copy Markdown

robodoo commented Apr 21, 2026

Pull request status dashboard

@SebVrc SebVrc changed the title Init PR sever - Technical Training Apr 21, 2026
@Mathilde411 Mathilde411 requested a review from delcourtfl April 21, 2026 13:31
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Just added a few general comments.

Comment thread estate/__manifest__.py Outdated
Comment thread estate/__manifest__.py Outdated
@SebVrc SebVrc force-pushed the 19.0-tutorials-sever branch from abe8e35 to 94bb329 Compare April 22, 2026 09:46
@SebVrc SebVrc self-assigned this Apr 23, 2026
@SebVrc SebVrc requested a review from delcourtfl April 23, 2026 14:49
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ! Everything is quite good already, just added a few minor remarks.

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/views/estate_menus.xml Outdated
Comment thread .gitignore
Comment thread README.md Outdated
@SebVrc SebVrc force-pushed the 19.0-tutorials-sever branch from 87bba41 to 2ddcfb0 Compare April 27, 2026 07:40
@SebVrc SebVrc force-pushed the 19.0-tutorials-sever branch from 2ddcfb0 to b250530 Compare April 27, 2026 07:52
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Good work already, just one nitpick.

Comment thread estate/models/estate_property.py Outdated
SebVrc and others added 7 commits April 27, 2026 15:47
This commit is here to introduce the testing framework of Odoo. Try running the
tests using `--test-tags :TestEstateProperty`.

Doc:
https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation

The tests were made such that the first one should work but the second one
should fail. Your job is to ensure both tests pass in the end. You should update
the behaviour of the appropriate models.

If you want, you can also add a small test of your own to get a feel for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants