Skip to content

19.0 belam technical training#1236

Open
belam-odoo wants to merge 8 commits intoodoo:19.0from
odoo-dev:19.0-belam-technical-training
Open

19.0 belam technical training#1236
belam-odoo wants to merge 8 commits intoodoo:19.0from
odoo-dev:19.0-belam-technical-training

Conversation

@belam-odoo
Copy link
Copy Markdown

First pull request in my technical training

This PR includes a hello message added and then removed.
And the first chapter of the training : the minimalistic creation of the estate module.

@robodoo
Copy link
Copy Markdown

robodoo commented Apr 21, 2026

Pull request status dashboard

@belam-odoo belam-odoo force-pushed the 19.0-belam-technical-training branch 3 times, most recently from d9b9b09 to 25da991 Compare April 22, 2026 08:42
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Good work already, just added a few comments.

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/security/__init__.py Outdated
Comment thread estate/__manifest__.py Outdated
Comment thread estate/__manifest__.py Outdated
@belam-odoo belam-odoo force-pushed the 19.0-belam-technical-training branch 10 times, most recently from 17c0205 to 935ad77 Compare April 27, 2026 09:41
Copy link
Copy Markdown

@delcourtfl delcourtfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ! Good work already, just a few comments/nitpicks.

(Also check the runbot style CI 👀)

Comment thread estate/models/__init__.py Outdated
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/views/__init__.py Outdated
Comment thread estate/views/customer_views.xml Outdated
Comment thread estate/__manifest__.py Outdated
Comment thread README.md Outdated
Comment thread estate/__manifest__.py Outdated
belam-odoo and others added 8 commits April 28, 2026 21:43
[IMP] estate: created module
Additional: some fixes based on recommendations
Improved list and form view for estate_property
Added search filters
Chapter 8
+ Added a validaty and deadline date for an offer and made them synchronized

Chapter 9
Added the possibility to mark the house as sold / cancelled
Added the possibility to validate / refuse offers
Created the interactions and protection rules for thoses processes
Improved UI a bit

[IMP] estate : chapters 8 & 9

Chapter 8
+ Added a validaty and deadline date for an offer and made them synchronized

Chapter 9
Added the possibility to mark the house as sold / cancelled
Added the possibility to validate / refuse offers
Created the interactions and protection rules for thoses processes
Improved UI a bit
Added contraints on models
Move some previous validation logic to constraints
This commit is here to introduce the testing framework of Odoo. Try running the
tests using `--test-tags :TestEstateProperty`.

Doc:
https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation

The tests were made such that the first one should work but the second one
should fail. Your job is to ensure both tests pass in the end. You should update
the behaviour of the appropriate models.

If you want, you can also add a small test of your own to get a feel for it.
@belam-odoo belam-odoo force-pushed the 19.0-belam-technical-training branch from 6baedea to f597615 Compare April 28, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants