vibad - technical trainning#1239
Open
nausicaa73 wants to merge 20 commits intoodoo:19.0from
Open
Conversation
|
|
vandroogenbd
left a comment
vandroogenbd
left a comment
There was a problem hiding this comment.
Off to a good start, I left some comments below about the formatting of your code. Also, your PR is missing a description 😉
Base users were able to unlink records although they're just plebs.
nausicaa73
force-pushed
the
19.0-tutorials-vibad
branch
from
e86cb22 to
b2e44d5
Compare
nausicaa73
force-pushed
the
19.0-tutorials-vibad
branch
from
b2823f8 to
7ab1515
Compare
| _order = "name" | ||
|
|
||
| name = fields.Char(required=True) | ||
| color = fields.Integer() |
There was a problem hiding this comment.
American english is ugly, too bad it's the default most of the time 😢
Suggested change
| color = fields.Integer() | |
| colour = fields.Integer() |
(don't apply this, it's just me ranting)
This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.