lugva - Technical Training#1240
Open
lugva-odoo wants to merge 18 commits intoodoo:19.0from
Open
Conversation
|
|
delcourtfl
requested changes
Apr 23, 2026
delcourtfl
left a comment
delcourtfl
left a comment
There was a problem hiding this comment.
Hello there ! Good work already, just a few comments.
delcourtfl
requested changes
Apr 24, 2026
delcourtfl
requested review from
vandroogenbd
and removed request for
vandroogenbd
Added declaration of the estate module as a new installable application. More can be found in Chapter 2 of Server Framework 101
Basic fields needed for the real estate property have been added. More can be found in Server framework 101, Chapter 3
Added security access rights for base group user to read, write, create and unlink. Read more in Server framework 101: Chapter 4
Added views for estate properties, now they can be added and modified. More can be found in Server framework 101, Chapter 5
Added basic views like list, form and search for the estate properties.More can be found in Server framework 101, Chapter 6
Added relationships to the property model, like property offers, property tags, property types.More can be found in Server framework 101, Chapter 7 [FIX] There was a wrong value for the property garden_orientation selection for the 'south' key. It was changed to 'South'
Added computed fields like best offer and total area, also used onchange to set default values for garden area and orientation. More can be found in Server framework 101, Chapter 8 [FIX] estate: resolvement of comments Fixed minor issues found during the review, like empty lines at the end of files, consistent usage of same type of quotes.
Added buttons to quickly set sold or cancelled statuses for properties. Also added buttons to accept and refuse offers. Read more in Server framework 101: Chapter 9
lugva-odoo
force-pushed
the
19.0-real-estate-lugva
branch
from
4f26ddc to
65910b5
Compare
Added security checks for different attributes of models which will validate user input. Read more in Server framework 101: Chapter 10 [FIX] general: adjust .gitignore .gitignore file was adjusted to ignore files made by VSCode
Improved the UI by adding different widgets, added widgets until tag colors including.
Added conditional visibility on different fields and rows in lists. Also made default search filters for properties. Then created a stat button for offers of a specific property type. More can be found in Server framework 101, Chapter 11 [FIX] estate: change property status on acceptance/reject Before property status was not changed when and offer was accepted or rejected, now it was changed.
Added constraints for deletion and creation of properties and offers. Also made it possible to view properties per salesperson in settings. More can be found in Server framework 101, Chapter 12 [FIX] estate: fix offer acceptance check Before I checked if buyer_id is set to see if there are any offers accepted. Now this has been improved by really looking for accepted offers. [FIX] estate: fix issues presented in code review Added newlines at the end of the file and improved code structure
Added invoicing possibilites when a property is sold. More can be found in Server framework 101, Chapter 13
Added kanban view for estate properties. They are grouped by property type. More can be found in Chapter 14 Server Framework 101
Fixed warnings in runbot. You can find them here: https://runbot.odoo.com/runbot/build/108834465 https://runbot.odoo.com/runbot/batch/2496180/build/108833606
lugva-odoo
force-pushed
the
19.0-real-estate-lugva
branch
from
e1d9ef9 to
09368e5
Compare
Unnecessary comments were removed from the xml
This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.
delcourtfl
reviewed
Apr 28, 2026
delcourtfl
left a comment
delcourtfl
left a comment
There was a problem hiding this comment.
Hello there ! Really good work, not much to say, you got the general idea for module development.
A test was added to your branch, if you have some extra time you can try to run/adapt it to ensure it works properly on your implementation.
Also to end this part in a clean way you should squash your commits (using an interactive rebase) into:
- one for estate module
- one for estate_account module
Added tests, and also functionality to not accept offers below expected price for south-oritented properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.