rohar - Technical Training#1242
Open
rohar-odoo wants to merge 11 commits intoodoo:19.0from
Open
Conversation
|
|
rohar-odoo
force-pushed
the
19.0-onboarding-rohar
branch
from
bcfd4ea to
a6d47e1
Compare
Mathilde411
requested changes
Apr 22, 2026
Mathilde411
left a comment
Mathilde411
left a comment
There was a problem hiding this comment.
Pretty good so far !
Runbot is green so good job !
Also would you be able to squash your commits so that you only have one per chapter ?
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
Suggested change
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 | |
| estate_property_access_user,estate.property.user,model_estate_property,base.group_user,1,1,1,1 |
Comments for each column:
1st column is the XMLid of the access right, it should be <model_name>_access_<concerned_group> (similarly to record rules in https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming)
second column is the name
2nd column is the name of the rule, the one that will be displayed in the ui, should say the model name and the targeted group (there is not really a fixed way, but a common one is with dots, like suggested)
3rd one is the xmlid of the model targeted, you don't need to add the module name in front if the xmlid is from the same module as you, same for 4th column that represents the targetted group
rohar-odoo
force-pushed
the
19.0-onboarding-rohar
branch
from
23066b8 to
9687c2b
Compare
rohar-odoo
force-pushed
the
19.0-onboarding-rohar
branch
from
9687c2b to
31493f7
Compare
Mathilde411
requested changes
Apr 24, 2026
Mathilde411
left a comment
Mathilde411
left a comment
There was a problem hiding this comment.
Good job here !
Here are a few things that I'd have done another way :)
rohar-odoo
force-pushed
the
19.0-onboarding-rohar
branch
from
1c48673 to
c200402
Compare
rohar-odoo
force-pushed
the
19.0-onboarding-rohar
branch
from
46eaf24 to
93e04e6
Compare
This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.