[ADD] estate: basic module creation by simal-odoo · Pull Request #1245 · odoo/tutorials

simal-odoo · 2026-04-22T08:16:24Z

Created init and manifest files

robodoo · 2026-04-22T08:16:27Z

Added fields in __manifest__.py Created models folder, EstateProperty model with the required fields and imported it in __manifest__.py files

Created data folder and file ir.model.access.csv inside it giving read, write, create and unlink permissions to the group base.group_user

Added views and actions for estate.property. Added a 3 level menu with the basic action Added and improved attributes

Mathilde411

Good job !
I was kinda nitpicky but this is a good job overall :)

- Added newlines to the relevant files - Changed license and version - Moved menus form data to views folder - Now follows formatting rules

Added list views to main menu Added form view when creating property Added search views, filters and group

Added property types and its menu and views Added property tags and its menu and views Added property offers and its views Added necessary fields and links

Added total area (garden area + living area) Added best price Added validity date Added onchanges on garden fields

Mathilde411

Pretty good :D

Mathilde411 · 2026-04-27T06:51:58Z

+    name = fields.Char('Property Name', required=True)
+    description = fields.Text('Description')
+    postcode = fields.Char('Postcode')
+    date_availability = fields.Date('Availability Date', copy=False, default=lambda self: fields.Date.add(fields.Date.today(), months=3))
+    expected_price = fields.Float('Expected Price', required=True)
+    selling_price = fields.Float('Selling Price', readonly=True, copy=False)
+    bedrooms = fields.Integer('Bedrooms', default=2)
+    living_area = fields.Integer('Living Area')
+    facades = fields.Integer('Facades')
+    garage = fields.Boolean('Garage')
+    garden = fields.Boolean('Garden')


Strings are not needed in most of those. The default would work.

Mathilde411 · 2026-04-27T06:54:10Z

+    @api.onchange('garden')
+    def _onchange_garden(self):
+        if not self.garden:
+            self.garden_area = 0
+            self.garden_orientation = False
+        else:
+            self.garden_area = 10
+            self.garden_orientation = 'north'
+
+    garden_area = fields.Integer('Garden Area')
+    garden_orientation = fields.Selection(
+        selection=[
+            ('north', 'North'),
+            ('south', 'South'),
+            ('east', 'East'),
+            ('west', 'West'),
+        ],
+    )
+    state = fields.Selection(
+        selection=[
+            ('new', 'New'),
+            ('offer received', 'Offer Received'),
+            ('offer accepted', 'Offer Accepted'),
+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled'),
+        ],
+        default='new',
+        required=True,
+    )
+    property_type_id = fields.Many2one('estate.property.type', string="Property Type")
+    buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False)
+    salesperson_id = fields.Many2one('res.users', string="Salesperson", default=lambda self: self.env.uid)
+    tag_ids = fields.Many2many('estate.property.tag', string="Property Tag")
+    offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offer")
+
+    @api.depends('living_area', 'garden_area')
+    def _compute_total_area(self):
+        for line in self:
+            line.total_area = line.living_area + line.garden_area
+    total_area = fields.Integer('Total Area', compute="_compute_total_area")
+
+    @api.depends('offer_ids.price')
+    def _compute_best_price(self):
+        for line in self:
+            line.best_price = max(line.mapped('offer_ids.price') or [0])
+    best_price = fields.Float('Best Offer', compute="_compute_best_price")


Be careful about attribute ordering in a model. fields should be before the rest and every type of method should be appearing in a set order

Mathilde411 · 2026-04-27T06:57:16Z

+    @api.depends('offer_ids.price')
+    def _compute_best_price(self):
+        for line in self:
+            line.best_price = max(line.mapped('offer_ids.price') or [0])


Suggested change

line.best_price = max(line.mapped('offer_ids.price') or [0])

line.best_price = max(line.mapped('offer_ids.price'), default=0)

a little bit better :)

Mathilde411 · 2026-04-27T06:58:50Z

+    partner_id = fields.Many2one("res.partner", string="Partner", required=True)
+    property_id = fields.Many2one("estate.property", string="Property", required=True)


On a many2one default string attribute is what comes before _id capitalized, so here it'd be the same, so you don't need to add it :)
Also works with many2many and one2many but with _ids instead of _id :D

Mathilde411 · 2026-04-27T07:01:47Z

+    @api.depends('create_date', 'validity')
+    def _compute_date_deadline(self):
+        for offer in self:
+            if offer.validity:
+                if offer.create_date:
+                    offer.date_deadline = offer.create_date + timedelta(days=offer.validity)
+                else:
+                    offer.date_deadline = fields.Date.today() + timedelta(days=offer.validity)
+            else:
+                offer.date_deadline = False


Validity is an integer field, it always has a value

Suggested change

@api.depends('create_date', 'validity')

def _compute_date_deadline(self):

for offer in self:

if offer.validity:

if offer.create_date:

offer.date_deadline = offer.create_date + timedelta(days=offer.validity)

else:

offer.date_deadline = fields.Date.today() + timedelta(days=offer.validity)

else:

offer.date_deadline = False

@api.depends('create_date', 'validity')

def _compute_date_deadline(self):

for offer in self:

offer.date_deadline = (offer.create_date or fields.Date.today()) + timedelta(days=offer.validity)

Mathilde411 · 2026-04-27T07:03:17Z

+    def _inverse_date_deadline(self):
+        for offer in self:
+            if offer.date_deadline:
+                if offer.create_date:
+                    offer.validity = (offer.date_deadline - offer.create_date).days
+                else:
+                    offer.validity = (offer.date_deadline - fields.Date.today()).days
+            else:
+                offer.validity = 0


Mathilde411 · 2026-04-27T07:03:30Z

+            else:
+                offer.validity = 0
+
+    date_deadline = fields.Date("Deadline", compute="_compute_date_deadline", inverse="_inverse_date_deadline", store=True)


Attribute ordering here too

Mathilde411 · 2026-04-27T07:07:12Z

+                <field name="price" width="200px"/>
+                <field name="partner_id" width="240px" />
+                <field name="validity" width="240px" />


Why the widths here ? Would this work correctly on all screen sizes or just yours ?

Added action to cancel or set a property as sold Added action to accept or refuse offer and set selling price and buyer

- Implemented required changes from PR - Fixed bug with deadline and validity of offers

- Added SQL constraints on expected price, offer price, tags and types - Added python constraint on selling price

This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.

[ADD] estate: basic module creation

94ed96c

Created init and manifest files

simal-odoo closed this Apr 22, 2026

simal-odoo reopened this Apr 22, 2026

Mathilde411 self-requested a review April 22, 2026 11:08

simal-odoo added 3 commits April 22, 2026 14:13

[ADD] estate: models and basic fields

3702745

Added fields in __manifest__.py Created models folder, EstateProperty model with the required fields and imported it in __manifest__.py files

[ADD] estate: add access rights for property model

ef29dbe

Created data folder and file ir.model.access.csv inside it giving read, write, create and unlink permissions to the group base.group_user

[ADD] estate: add basic user interface

2ba81c0

Added views and actions for estate.property. Added a 3 level menu with the basic action Added and improved attributes

Mathilde411 requested changes Apr 23, 2026

View reviewed changes

simal-odoo added 2 commits April 23, 2026 09:56

[CLN] estate: implemented requested changes

6aa8bbe

- Added newlines to the relevant files - Changed license and version - Moved menus form data to views folder - Now follows formatting rules

[ADD] estate: add views

70fa394

Added list views to main menu Added form view when creating property Added search views, filters and group

simal-odoo force-pushed the 19.0-technical-training-simal branch from 0b858e1 to 70fa394 Compare April 23, 2026 13:05

simal-odoo added 2 commits April 24, 2026 09:49

[ADD] estate: add models and relations

32f65b1

Added property types and its menu and views Added property tags and its menu and views Added property offers and its views Added necessary fields and links

[ADD] estate: computed fields and onchanges

00ddb13

Added total area (garden area + living area) Added best price Added validity date Added onchanges on garden fields

Mathilde411 requested changes Apr 27, 2026

View reviewed changes

simal-odoo and others added 4 commits April 27, 2026 09:56

[ADD] estate: added actions

3cb24f9

Added action to cancel or set a property as sold Added action to accept or refuse offer and set selling price and buyer

[FIX] estate: cleaned and fixed code

149b4e5

- Implemented required changes from PR - Fixed bug with deadline and validity of offers

[ADD] estate: add constraints

c2166b8

- Added SQL constraints on expected price, offer price, tags and types - Added python constraint on selling price

	line.best_price = max(line.mapped('offer_ids.price') or [0])
	line.best_price = max(line.mapped('offer_ids.price'), default=0)

		partner_id = fields.Many2one("res.partner", string="Partner", required=True)
		property_id = fields.Many2one("estate.property", string="Property", required=True)

Conversation

simal-odoo commented Apr 22, 2026

Uh oh!

robodoo commented Apr 22, 2026

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants