Real Estate Tutorial (raame)#1248
Open
raame-odoo wants to merge 9 commits intoodoo:19.0from
Open
Conversation
|
|
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
from
9f184e7 to
7371099
Compare
…nd access rights A new estate module was created. Property model was created as well and contains some fields. Access rights were added.
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
from
7371099 to
6a48a78
Compare
vandroogenbd
left a comment
vandroogenbd
left a comment
There was a problem hiding this comment.
Not much to say, runbot is green... Keep going! 🚀
Comment on lines
+6
to
+8
| _description = "Properties of the estate" | ||
|
|
||
| name = fields.Char(required=True) |
There was a problem hiding this comment.
Good practice to separate attributes from fields 👍
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_property_model,access_property_model,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
It is good practice to add a trailing empty line to your files
| { | ||
| 'name': 'Real Estate', | ||
| 'depends': [ | ||
| 'base' |
There was a problem hiding this comment.
It is good practice to end such lines with a ,. This way, if someone later adds a line, they don't have to add the coma so the line stays unchanged, this keeps the git history cleaner!
| 'security/ir.model.access.csv' | ||
| ], | ||
| 'application': True, | ||
| 'license': 'AGPL-3' |
|
Forgot to say, please add a description to the PR |
Base users were able to unlink records although they're just plebs.
Added an xml file for actions. Also added the 3 levels of menu items and linked them to actions. Finally, some new fields were added like active and state. Some new attributes were added to new and existing fields.
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
from
0acc010 to
9d4d467
Compare
List view, form view, and search with filter were added in this Chapter
Many2one fields and One2many fields were added to represent types, tags, and offers
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
from
8570dc0 to
7876339
Compare
Added computed fields, inverse methods, and onchange methods
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
2 times, most recently
from
577213f to
23e6402
Compare
Added action buttons
raame-odoo
force-pushed
the
19.0-tutorial-raame
branch
from
23e6402 to
88c7d39
Compare
This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.
Added constraint and changed behaviour to pass the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for the Real Estate Module Tutorial