Open
Conversation
make a counter that adds 1 every time a button is pressed
making sure the counter can be reused
have a view of how properties can be used to customize components
make it possible to use markup in cards
make sure the correct properties are defined, can be validated in developer mode
make it possible to have the total of different counters together
bring an option to the user to have a todolist visible
|
|
make it visually clear when is task is completed
cgun-odoo
reviewed
Apr 27, 2026
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| import { Component } from "@odoo/owl"; | ||
|
|
||
| export class Card extends Component { | ||
| static template = "awesome_owl.card"; |
There was a problem hiding this comment.
Name for the template is usually camel case
Suggested change
| static template = "awesome_owl.card"; | |
| static template = "awesome_owl.Card"; |
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
Suggested change
| <?xml version="1.0" encoding="UTF-8" ?> |
| import { Component } from "@odoo/owl"; | ||
|
|
||
| export class TodoItem extends Component { | ||
| static template = "awesome_owl.todo_item"; |
There was a problem hiding this comment.
Suggested change
| static template = "awesome_owl.todo_item"; | |
| static template = "awesome_owl.TodoItem"; |
make the list of todo's interactive by adding the option to add items
when loading the page automatically focus the input as this improves the speed of adding a new item when loading the page
make it possible to toggle a todo to completed
make code in line with teh current standard
make it possible to delete wrong todo items
make it possible to delete wrong todo items
add option to hide card content
make the app follow the common layout to keep the same look and feel over the complete environment
make it easier to navigate between the different parts
cgun-odoo
reviewed
Apr 28, 2026
cgun-odoo
left a comment
cgun-odoo
left a comment
There was a problem hiding this comment.
Couldn't find anything to complain about nice job
| <div class="border d-inline-block p-2 m-2" style="width: 18rem;"> | ||
| <t t-foreach="todos" t-as="todo" t-key="todo"> | ||
| <TodoItem todo="todo"/> | ||
| <input t-ref="add_todo_input" t-on-keyup="addToDo" placeholder="Add a todo"/> |
There was a problem hiding this comment.
from what i see in Odoo, t-ref values are also camelCase rather than snake_case
make it possible to see some content on the page
it is better to show requested data over dummy data
by caching results through a service you don't need to call backend every time you want to show the statistics
add visualization for the statistic data of sizes
code convention
code convention filename needs to be like element inside
…g next one the order of first deleting the old canvas and only then adding a new chart is important!
making sure the data is in line with the data from the backend
cgun-odoo
reviewed
Apr 28, 2026
Comment on lines
+24
to
+26
| if (this.chart) { | ||
| this.chart.destroy(); | ||
| } |
There was a problem hiding this comment.
you could also do this.chart?.destroy();
Comment on lines
+31
to
+38
| type: "pie", data: { | ||
| labels: Object.keys(this.props.data), | ||
| datasets: [ | ||
| { | ||
| data: Object.values(this.props.data), | ||
| }, | ||
| ], | ||
| } |
There was a problem hiding this comment.
Suggested change
| type: "pie", data: { | |
| labels: Object.keys(this.props.data), | |
| datasets: [ | |
| { | |
| data: Object.values(this.props.data), | |
| }, | |
| ], | |
| } | |
| type: "pie", | |
| data: { | |
| labels: Object.keys(this.props.data), | |
| datasets: [ | |
| { | |
| data: Object.values(this.props.data), | |
| }, | |
| ], | |
| } |
only load the dashboards when they need to be shown
change hardcode cards to a list of dashboard_items to make customization possible in a later stage
help with readability of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.