Security: Sensitive response data may be exposed through exception messages#526
Open
tomaioo wants to merge 1 commit intookta:masterfrom
Open
Conversation
The SDK embeds raw server response content directly into exception messages (`HTTPError.message` includes `response_body`, and `OktaAPIError.message` includes server-provided summaries/causes). If these exceptions are logged or surfaced to clients, they can leak sensitive details such as tokens, identifiers, internal error context, or PII returned by upstream services. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Sensitive response data may be exposed through exception messages
Problem
Severity:
Medium| File:okta/errors/http_error.py:L20The SDK embeds raw server response content directly into exception messages (
HTTPError.messageincludesresponse_body, andOktaAPIError.messageincludes server-provided summaries/causes). If these exceptions are logged or surfaced to clients, they can leak sensitive details such as tokens, identifiers, internal error context, or PII returned by upstream services.Solution
Avoid including full raw response bodies in exception strings. Redact sensitive fields (e.g., tokens, secrets, user identifiers), truncate long payloads, and store full response details only in structured/internal debug fields guarded by secure logging controls.
Changes
okta/errors/http_error.py(modified)