Skip to content

refactor: use strings.builder #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chuanshanjida wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

refactor: use strings.builder #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/dependencymanager/dependencyinstaller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"encoding/hex"
"fmt"
"path/filepath"
"strings"

"github.com/psiemens/sconfig"

Expand Down Expand Up @@ -585,19 +586,19 @@ func (di *DependencyInstaller) fetchDependenciesWithDepth(dependency config.Depe
}

// Log installation with visual hierarchy and branding colors
indent := ""
var indent strings.Builder
prefix := ""

if depth > 0 {
// Create indentation with proper tree characters
for i := 0; i < depth; i++ {
indent += " "
indent.WriteString(" ")
}
prefix = "├─ "

// Add depth limit warning for very deep chains
if depth >= 5 {
di.Logger.Info(fmt.Sprintf("%s⚠️ Deep dependency chain (depth %d)", indent, depth))
di.Logger.Info(fmt.Sprintf("%s⚠️ Deep dependency chain (depth %d)", indent.String(), depth))
}
}

Expand All @@ -606,7 +607,7 @@ func (di *DependencyInstaller) fetchDependenciesWithDepth(dependency config.Depe
shortAddress := "0x..." + fullAddress[len(fullAddress)-4:]
addressStyled := branding.GreenStyle.Render(shortAddress)
networkStyled := branding.GrayStyle.Render(networkName)
di.Logger.Info(fmt.Sprintf("%s%s%s @ %s (%s)", indent, prefix, contractNameStyled, addressStyled, networkStyled))
di.Logger.Info(fmt.Sprintf("%s%s%s @ %s (%s)", indent.String(), prefix, contractNameStyled, addressStyled, networkStyled))
di.installCount++

err := di.addDependency(dependency)
Expand Down
Loading