Open
Conversation
The code that is submitted via the AskSage method no longer works with the newer versions of Sage and needs to be updated. Also the public Sage cell server at https://sagecell.sagemath.org/service no longer accepts public code via its `service` endpoint. So make the URL for a sagecell server configurable. Files for building a sagecell server and deploying it via docker have been added in the `fsagecell-docker` directory. Instructions for doing so are in the `sagecell-docker/README.md` file. Remove the `accepted_tos` parameter from the `AskSage` call. Just add the parameter internally, and stop requiring that the author do so. It is a meaningless gesture to force the author to do so. Furthermore, the docker build is set to not require that parameter. Also make it so that the `AskSage` method can be called without passing any arguments, since there are now none that are required.
drgrice1
force-pushed
the
asksage-update
branch
from
29b9951 to
15f5d8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that is submitted via the AskSage method no longer works with the newer versions of Sage and needs to be updated.
Also the public Sage cell server at https://sagecell.sagemath.org/service no longer accepts public code via its
serviceendpoint. So make the URL for a sagecell server configurable.Files for building a sagecell server and deploying it via docker have been added in the
fsagecell-dockerdirectory. Instructions for doing so are in thesagecell-docker/README.mdfile.Remove the
accepted_tosparameter from theAskSagecall. Just add the parameter internally, and stop requiring that the author do so. It is a meaningless gesture to force the author to do so. Furthermore, the docker build is set to not require that parameter.Also make it so that the
AskSagemethod can be called without passing any arguments, since there are now none that are required.