Fix the aria label for the zoom out button of the imageview dialog.#1400
Open
drgrice1 wants to merge 1 commit intoopenwebwork:PG-2.21from
Open
Fix the aria label for the zoom out button of the imageview dialog.#1400drgrice1 wants to merge 1 commit intoopenwebwork:PG-2.21from
drgrice1 wants to merge 1 commit intoopenwebwork:PG-2.21from
Conversation
Testing things with the screen reader revealed this. The zoom out button has the same aria label as the zoom in button. This was probably a cut and paste error. Also remove the `zoom-in` class on both that is not needed or used for either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing things with the screen reader revealed this. The zoom out button has the same aria label as the zoom in button. This was probably a cut and paste error.
Also remove the
zoom-inclass on both that is not needed or used for either.