Remove PRINT_FILE_NAMES_FOR and PRINT_FILE_NAMES_PERMISSION_LEVEL#2952
Open
dlglin wants to merge 2 commits intoopenwebwork:WeBWorK-2.21from
Open
Remove PRINT_FILE_NAMES_FOR and PRINT_FILE_NAMES_PERMISSION_LEVEL#2952dlglin wants to merge 2 commits intoopenwebwork:WeBWorK-2.21from
dlglin wants to merge 2 commits intoopenwebwork:WeBWorK-2.21from
Conversation
drgrice1
reviewed
Apr 20, 2026
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
With this pull request there are no longer any valid $courseOptions. The only thing this has was used for was for writing the course.conf file, and the only thing that was left in it was the PRINT_FILE_NAMES_FOR option. So it should be removed from the code entirely. Both in the CourseManagement.pm file and in the CourseAdmin.pm file.
Furthermore, the writeCourseConf method in CourseManagement.pm doesn't need any arguments anymore other than the file handle to write to.
I have already done this, and will put a pull request in to this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the special PG environment variables
PRINT_FILE_NAMES_FORandPRINT_FILE_NAMES_PERMISSION_LEVEL.In defaults.config the value of
PRINT_FILE_NAMES_PERMISSION_LEVELis set to the value of theprint_path_to_problempermission, so now that permission is just checked directly.I don't see the use of
PRINT_FILE_NAMES_FOR. When a new course is created it is hardcoded to add all users with permission level of 'professor' or higher to the array, but those users will already be able to view file names via theprint_path_to_problempermission.The motivation behind this was to remove the one remaining setting that is added to course.conf when a new course is created. Now that file contains no settings by default.