Skip to content

improve: integration test for corner case for activation condition#3296

Merged
csviri merged 2 commits intooperator-framework:mainfrom
csviri:impr-wf-test
Apr 16, 2026
Merged

improve: integration test for corner case for activation condition#3296
csviri merged 2 commits intooperator-framework:mainfrom
csviri:impr-wf-test

Conversation

@csviri
Copy link
Copy Markdown
Collaborator

@csviri csviri commented Apr 15, 2026

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copilot AI review requested due to automatic review settings April 15, 2026 18:19
@openshift-ci openshift-ci bot requested review from metacosm and xstefank April 15, 2026 18:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the onedependentactivationcondition integration-test scenario to exercise a corner case where a dependent resource type is “not available” (via a custom resource type) while its activation condition prevents it from being reconciled.

Changes:

  • Switch the workflow dependent in OneDependentActivationConditionReconciler from a ConfigMap-based dependent to NotAvailableDependentResource.
  • Update the dependent resource implementation to target a new NotAvailableCustomResource type.
  • Add NotAvailableCustomResource test CRD type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/onedependentactivationcondition/OneDependentActivationConditionReconciler.java Switches workflow dependent type to NotAvailableDependentResource to test the “not available dependent” corner case.
operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/onedependentactivationcondition/NotAvailableDependentResource.java Updates dependent to produce NotAvailableCustomResource instead of a ConfigMap.
operator-framework/src/test/java/io/javaoperatorsdk/operator/workflow/onedependentactivationcondition/NotAvailableCustomResource.java Introduces a new test CustomResource type used by the dependent.

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri merged commit a98f494 into operator-framework:main Apr 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants