Conversation
| <maximum>65535</maximum> | ||
| <ValidationMessage>Please specify a valid port.</ValidationMessage> | ||
| </wireguardPort> | ||
| <ipmapping type="TextField"> |
There was a problem hiding this comment.
CSVListField is encouraged as it can do per-item masks. 12.34.56.80/eth1 is pretty funky syntax -- what does it do?
There was a problem hiding this comment.
There was a problem hiding this comment.
https://docs.netbird.io/get-started/cli#flags
The whole option is written weirdly. It maps the interface to a manually-mapped IP
There was a problem hiding this comment.
I guess it's fine as long as we can make the regex per item instead of mocking a CSV regex
There was a problem hiding this comment.
I am not sure how to do this differently
There was a problem hiding this comment.
@fichtner If you have a moment to help here with the regex.
|
Except for the possible changes needed on the regex, I think it's fine. |
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
Describe the proposed solution
Related issue
Closes: #5325