Change default mtree schema from "spock" to "pgedge_ace"#116
Merged
mason-sharp merged 2 commits intomainfrom Apr 22, 2026
Merged
Change default mtree schema from "spock" to "pgedge_ace"#116mason-sharp merged 2 commits intomainfrom
mason-sharp merged 2 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughThe default Merkle-tree CDC metadata schema changed from "spock" to "pgedge_ace" across configs, docs, and tooling. Changes
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@visualise.sh`:
- Around line 37-40: The ace_schema value parsed from getopts (flag -S) is
user-controlled and must be validated before being interpolated into SQL
identifiers; add a validation step in visualise.sh after getopts (or immediately
after assigning ace_schema) that rejects any value that does not match a safe
SQL identifier pattern (e.g., starts with a letter or underscore and contains
only letters, digits or underscores), print a clear error mentioning the -S
argument and ace_schema, and exit non‑zero; ensure the validation is applied to
ace_schema before any use in SQL-building code paths (references: ace_schema,
getopts handling for -S).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 26d8201f-292b-4deb-bfba-396f166093f7
📒 Files selected for processing (5)
ace.yamldocs/CHANGELOG.mddocs/configuration.mdinternal/cli/default_config.yamlvisualise.sh
Update ace.yaml, default_config.yaml, configuration docs, and visualise.sh. Add -S flag to visualise.sh for schema override. CHANGELOG documents the breaking change and migration path.
mason-sharp
force-pushed
the
task/default-schema
branch
from
e528c2c to
23b7e44
Compare
Counts alone miss UPDATE-only drift: subtests that modify field values without changing row counts leave the two-node table content temporarily divergent while their cleanup repair replicates. The old gate returned immediately in that window, letting the next subtest start against drifted state. Add a hashtext-sum row digest alongside the count check. The digest is order-independent and PK-agnostic, so it generalises across tables and catches UPDATE-induced drift that counts cannot see.
ibrarahmad
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ace.yaml, default_config.yaml, configuration docs, and visualise.sh. Add -S flag to visualise.sh for schema override. CHANGELOG documents the breaking change and migration path.
Users of mtree functionality with previous versions will want to change their default schema back to "spock".
Also make tests less flakey