Update sub_show_status() reference with status values#429
Update sub_show_status() reference with status values#429susan-pgedge wants to merge 1 commit intomainfrom
Conversation
…tting fixes Add a STATUS VALUES table documenting all five possible subscription states (replicating, initializing, disabled, down, unknown) derived from the C source. Fix heading markup, wrap synopsis in a fenced SQL code block, and add introductory sentences before examples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe documentation for Changes
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/spock_functions/functions/spock_sub_show_status.md`:
- Around line 57-58: The parameter description for subscription_name in the
spock_sub_show_status documentation is indented with four spaces and is being
rendered as a code block; update the
docs/spock_functions/functions/spock_sub_show_status.md entry for
subscription_name (the parameter in the spock_sub_show_status function) by
removing the leading four-space indentation and making it plain prose (or
convert it to a proper definition-list style), so the sentence "Optional. The
name of a specific Spock subscription. If NULL (the default), the function
returns status for all subscriptions." renders as normal text instead of a code
block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 347587e4-765b-4ed4-a2f3-09000fcafb15
📒 Files selected for processing (1)
docs/spock_functions/functions/spock_sub_show_status.md
| Optional. The name of a specific Spock subscription. If NULL | ||
| (the default), the function returns status for all subscriptions. |
There was a problem hiding this comment.
Fix parameter description formatting.
The description for subscription_name uses 4-space indentation, which markdown interprets as a code block rather than prose text. This causes rendering issues.
📝 Proposed fix to use proper markdown formatting
Option 1: Use definition list style with minimal indentation:
subscription_name
- Optional. The name of a specific Spock subscription. If NULL
- (the default), the function returns status for all subscriptions.
+: Optional. The name of a specific Spock subscription. If NULL
+ (the default), the function returns status for all subscriptions.
Option 2: Remove indentation entirely:
subscription_name
- Optional. The name of a specific Spock subscription. If NULL
- (the default), the function returns status for all subscriptions.
+Optional. The name of a specific Spock subscription. If NULL
+(the default), the function returns status for all subscriptions.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Optional. The name of a specific Spock subscription. If NULL | |
| (the default), the function returns status for all subscriptions. | |
| subscription_name | |
| : Optional. The name of a specific Spock subscription. If NULL | |
| (the default), the function returns status for all subscriptions. |
| Optional. The name of a specific Spock subscription. If NULL | |
| (the default), the function returns status for all subscriptions. | |
| subscription_name | |
| Optional. The name of a specific Spock subscription. If NULL | |
| (the default), the function returns status for all subscriptions. |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 57-57: Code block style
Expected: fenced; Actual: indented
(MD046, code-block-style)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/spock_functions/functions/spock_sub_show_status.md` around lines 57 -
58, The parameter description for subscription_name in the spock_sub_show_status
documentation is indented with four spaces and is being rendered as a code
block; update the docs/spock_functions/functions/spock_sub_show_status.md entry
for subscription_name (the parameter in the spock_sub_show_status function) by
removing the leading four-space indentation and making it plain prose (or
convert it to a proper definition-list style), so the sentence "Optional. The
name of a specific Spock subscription. If NULL (the default), the function
returns status for all subscriptions." renders as normal text instead of a code
block.
This resolves spoc-361
Add a STATUS VALUES table documenting all five possible subscription states (replicating, initializing, disabled, down, unknown) derived from the C source. Fix heading markup, wrap synopsis in a fenced SQL code block, and add introductory sentences before examples.