Conversation
- Guard Resizer drag-hide behind the collapsible flag so non-collapsible
panels (main-toolbar, pane splitters, bottom-panel-container) cannot
be squeezed to zero and hidden when maxsize is driven below 10px by a
narrow window.
- Floor main-toolbar's data("maxsize") at its minimum width in
updateResizeLimits, so narrow-window/wide-sidebar cases cannot cap
the toolbar below usable size.
- Add _getSidebarWidth() using offsetWidth; jQuery outerWidth() returns
the stale style.width on a display:none sidebar, which corrupted the
layout math.
- Re-clamp the plugin panel when the sidebar is shown/hidden/resized.
- Add _ensureEditorLayoutFits(): in editor mode, coordinate sidebar,
editor, and plugin-panel so all three share the window. Shrinks the
sidebar after toolbar clamping if sidebar + CCB + toolbar + min
editor exceeds the window width. No-op in design mode, which pins
its own geometry with !important.
The toggle handler hardcoded fa-feather when exiting design mode, overwriting the pen-nib icon set in HTML.
- Inline the SVG in index.html so it renders on first paint without a blank-button flash. - Switch fills/strokes to currentColor so the icon picks up the CCB button color and hover/active states. - Cache the rendered SVG HTML at init; the toggle swaps it with an fa-code icon for design-mode state and restores the cached SVG on return to editor mode. - Size the inline SVG to 15px via CSS to match neighboring FA icons.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
panels (main-toolbar, pane splitters, bottom-panel-container) cannot
be squeezed to zero and hidden when maxsize is driven below 10px by a
narrow window.
updateResizeLimits, so narrow-window/wide-sidebar cases cannot cap
the toolbar below usable size.
the stale style.width on a display:none sidebar, which corrupted the
layout math.
editor, and plugin-panel so all three share the window. Shrinks the
sidebar after toolbar clamping if sidebar + CCB + toolbar + min
editor exceeds the window width. No-op in design mode, which pins
its own geometry with !important.