Backport: Fix ObjectEncoder dropping attributes with falsy values#62
Merged
Backport: Fix ObjectEncoder dropping attributes with falsy values#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the fix from #60 to the
0.31.xbranch, so a0.31.1patch release can be tagged for projects still on PHP 8.3 that cannot upgrade to0.32.x(which raised the minimum PHP version to 8.4 and bumped several dependencies).Closes #61.
Credit to @ademarco for the original backport patch (openeuropa#1).
Changes
ObjectEncoder.php: use$value !== nullinstead of a truthy check, so falsy attribute values (false,0,0.0,"") are still encoded.Test plan
vendor/bin/phpunitpasses locally (564 tests, 1156 assertions)