Skip to content

keywords: add NDVRATE#22746

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hfxsd:add-NDVRATE-keyword
Apr 14, 2026
Merged

keywords: add NDVRATE#22746
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hfxsd:add-NDVRATE-keyword

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Apr 13, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Apr 13, 2026
@hfxsd hfxsd requested a review from dveeden April 13, 2026 14:19
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2026
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the NDVRATE keyword to the list of TiDB keywords in keywords.md. I have no feedback to provide as there are no review comments to evaluate.

@hfxsd hfxsd mentioned this pull request Apr 13, 2026
14 tasks
github-actions bot added a commit to hfxsd/docs-cn that referenced this pull request Apr 13, 2026
Synced from: pingcap/docs#22746
Target PR: pingcap#21544
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 13, 2026
@dveeden
Copy link
Copy Markdown
Contributor

dveeden commented Apr 13, 2026

Looks like there were two new keywords: NDVRATE and RAW

Co-authored-by: Daniël van Eeden <github@myname.nl>
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2026
@hfxsd hfxsd added the lgtm label Apr 13, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Apr 14, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 14, 2026
@ti-chi-bot ti-chi-bot bot merged commit f0b22c1 into pingcap:master Apr 14, 2026
11 of 12 checks passed
@hfxsd hfxsd removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 14, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22747.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 14, 2026
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 14, 2026
Synced from: pingcap/docs#22746
Target PR: pingcap#21544
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants