fix: use --preload for Bun instead of --import#22
Merged
Conversation
- Added test case verifying buildRunnerCommand uses --preload for Bun - Consistent with @pokujs/dom fix
Lojhan
force-pushed
the
fix/bun-preload-flag
branch
2 times, most recently
from
2ea0417 to
0142688
Compare
Lojhan
force-pushed
the
fix/bun-preload-flag
branch
from
cfca016 to
58c3b5d
Compare
Lojhan
force-pushed
the
fix/bun-preload-flag
branch
from
70650c7 to
1f0b37b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR adds a test case that verifies the buildRunnerCommand function correctly handles Bun's CLI arguments. The actual fix is implemented in @pokujs/dom (the core package), which is imported by @pokujs/react.
Bun requires `--preload` as a positional argument (e.g., `--preload /path/to/file`) rather than `--import=/path/to/file` which is used for Node.js and Deno.
Test
Added test case verifying that `buildRunnerCommand` produces `--preload /tmp/react-dom-setup.ts` for Bun runtime.