Open
Conversation
Member
|
I don't have a problem with this in principle, maybe @davidstrauss has some thoughts though. Have you tried this with nginx or another non-apache webserver to make sure it still behaves correctly? You might consider and update hook to force the path_cache to clear when this change goes out so there's not wasted space on unreachable paths. |
Member
Have you tried this with nginx or another non-apache webserver to make sure it still behaves correctly? This should work fine on any web server. You might consider and update hook to force the path_cache to clear when this change goes out so there's not wasted space on unreachable paths. I personally wouldn't bother. Most caches use a combination of expiration and LRU that make keeping around harmless stale items better than explicitly spending time in PHP to clear them. |
pdrakeweb
pushed a commit
to pdrakeweb/6
that referenced
this pull request
Mar 12, 2012
This pull request includes a merge of 6.23 and the 4 feature branches listed below.
|
The URL to the original issue is dead :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for https://bugs.launchpad.net/pressflow/+bug/884171