Split tooling changes (removed-token lint, Husky hook, CI depth) from docs PR #1361#1362
Draft
Copilot wants to merge 3 commits intodocs/color-scales-guidefrom
Draft
Split tooling changes (removed-token lint, Husky hook, CI depth) from docs PR #1361#1362Copilot wants to merge 3 commits intodocs/color-scales-guidefrom
Copilot wants to merge 3 commits intodocs/color-scales-guidefrom
Conversation
|
Copilot
AI
changed the title
[WIP] [WIP] Addressing review feedback on color scales and contrast patterns documentation
Split tooling changes (removed-token lint, Husky hook, CI depth) from docs PR #1361
Apr 29, 2026
Collaborator
Contributor
Author
Draft
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #1361 that mixed tooling changes with documentation. This PR isolates the tooling changes into a dedicated branch.
Summary
Splits out the tooling changes that were bundled into the color-scales docs PR (#1361).
COLOR_SCALES.mdlives in the base branch #1361 and is kept in sync via merge. This branch contains only the operational changes needed to enforce removed-token tracking.List of notable changes:
scripts/checkRemovedTokens.ts— lint script that detects token deletions/renames not documented insrc/tokens/removed/scripts/utilities/extractTokenNames.ts+.test.ts— token name extraction utility with 7 unit testspackage.json:lint:removedscript wired intonpm run lint.github/workflows/ci.yml:fetch-depth: 0so CI can resolvemerge-basewith main.husky/pre-commit: runscheckRemovedTokensagainstBASE_REF(falls back toorigin/main) before each commitsrc/tokens/removed/removed.json: consolidated single tracking file (replacescolor.json), adding 310 missing historical removed/renamed token entries across v7.11.2–v11.7.0contributor-docs/agents/token-authoring.md: documents the removal/rename tracking processdocs/color-scales-guide— keepingCOLOR_SCALES.mdversion from docs: add comprehensive guide to color scales and contrast patterns #1361What should reviewers focus on?
checkRemovedTokens.tslogic for detecting disappeared token names viagit merge-basediffremoved.jsonconsolidation — correctness of the 310 added historical entriesBASE_REFdetection viagit symbolic-refwithorigin/mainfallbackSteps to test:
src/tokens/without updatingsrc/tokens/removed/removed.jsonnpm run lint:removed— expect a failure listing the undocumented removalremoved.jsonand re-run — expect✅ No tokens were removedgit commitwith an undocumented removal — expect the pre-commit hook to block itSupporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: