-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
gh-146406: Add cross-language method suggestions for builtin AttributeError #146407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvanhorn
wants to merge
14
commits into
python:main
Choose a base branch
from
mvanhorn:osc/cross-language-attr-hints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+265
−6
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7adad8b
Add cross-language method suggestions for builtin AttributeError
mvanhorn aecaacb
fix NEWS entry filename for bedevere bot
mvanhorn 6d58cdc
Address review feedback from @nedbat and @ZeroIntensity
mvanhorn 8a39e32
Add What's New entry for cross-language AttributeError hints
mvanhorn 196dbe4
Address review feedback from @picnixz
mvanhorn 99e106a
Keep Levenshtein criterion, remove survey restriction per picnixz
mvanhorn 57a4d39
Consolidate cross-language tests, shorten raw-message hints
mvanhorn 2a2c0d5
test: restructure test_cross_language to use assertEndsWith for full …
mvanhorn f702e79
Use MappingProxyType for _CROSS_LANGUAGE_HINTS per vstinner review
mvanhorn 3ad54c8
Update Lib/traceback.py
vstinner 0089761
Add blank line before criteria list per review
mvanhorn e2c12ec
Address serhiy-storchaka feedback: isinstance, mutable/immutable, Non…
mvanhorn 564ca3a
Fix test_cross_language_works_for_subclasses CI failure
mvanhorn e1eb6f4
Address vstinner review: frozendict wrapper, types.NoneType, doctest
mvanhorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
Misc/NEWS.d/next/Library/2026-03-25-07-17-41.gh-issue-146406.ydsmqe.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Cross-language method suggestions are now shown for :exc:`AttributeError` on | ||
| builtin types and their subclasses. | ||
| For example, ``[].push()`` suggests ``append``, | ||
| ``(1,2).append(3)`` suggests using a ``list``, | ||
| ``None.keys()`` suggests expecting a ``dict``, | ||
| and ``1.0.__or__`` suggests using an ``int``. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that suggestions on None are useful, but @serhiy-storchaka suggested them. For me, they sound a little bit too generic.