gh-131798: split _CALL_BUILTIN_CLASS to smaller uops#148094
Merged
kumaraditya303 merged 4 commits intopython:mainfrom Apr 10, 2026
Merged
gh-131798: split _CALL_BUILTIN_CLASS to smaller uops#148094kumaraditya303 merged 4 commits intopython:mainfrom
_CALL_BUILTIN_CLASS to smaller uops#148094kumaraditya303 merged 4 commits intopython:mainfrom
Conversation
kumaraditya303
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
| PyObject *callable_o = sym_get_const(ctx, callable); | ||
| if (callable_o && sym_matches_type(callable, &PyType_Type)) { | ||
| PyTypeObject *tp = (PyTypeObject *)callable_o; | ||
| if (tp->tp_vectorcall != NULL) { |
Member
There was a problem hiding this comment.
Just checking, they are not expected to modify this without modifying the type version right?
Contributor
Author
There was a problem hiding this comment.
I don't think tp_vectorcall is supposed to be modified after a type is created
Fidget-Spinner
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.