gh-148352: Add more colour to calendar CLI output#148354
Open
hugovk wants to merge 5 commits intopython:mainfrom
Open
gh-148352: Add more colour to calendar CLI output#148354hugovk wants to merge 5 commits intopython:mainfrom
calendar CLI output#148354hugovk wants to merge 5 commits intopython:mainfrom
Conversation
sharktide
reviewed
Apr 10, 2026
Co-authored-by: Rihaan Meher <sharktidedev@gmail.com>
sharktide
reviewed
Apr 10, 2026
| @@ -0,0 +1 @@ | |||
| Add more colour to :mod:`calendar`'s CLI output. Patch by Hugo van Kemenade. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Add more colour to :mod:`calendar`'s CLI output. Patch by Hugo van Kemenade. | |
| Add more color to :mod:`calendar`'s CLI output. Patch by Hugo van Kemenade. |
I’m in favor of using American English since that is how most of the docs are written, but up to you ;)
| parser.add_argument( | ||
| "-f", "--first-weekday", | ||
| type=int, default=0, | ||
| help="weekday (0 is Monday, 6 is Sunday) to start each week (default 0)" |
Contributor
There was a problem hiding this comment.
Why stop telling the user the defaults? I think it adds clarity in certain situations :) up to you however
Contributor
|
Test fails unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.14, we added an amazing colour highlight for today: #128318.
Let's add a touch more colour.
calendarCLI output #148352📚 Documentation preview 📚: https://cpython-previews--148354.org.readthedocs.build/