RDKB-62529: Able to access the blocked port HTTPS sites by suriya-prem · Pull Request #283 · rdkcentral/utopia

suriya-prem · 2026-04-03T11:09:20Z

RDKB-62529: Able to access the blocked port HTTPS sites

Reason for change: Blocked port HTTPS site is accessible.
Test Procedure: Add HTTPS port in managed services in parental control.
Risks: Low
Priority: P1
Signed-off-by: suriyanarayanan_mp@comcast.com

Copilot

Pull request overview

Updates firewall rule generation to prevent HTTPS (port 443) access from bypassing Parental Control “Managed Services” port blocks by conditionally suppressing the existing blockssl ACCEPT/DROP rules when Managed Services includes port 443.

Changes:

Add detection of whether Managed Services config includes port 443 (ms_has_port_443).
Adjust the condition that emits blockssl (TCP/UDP 443) rules so it won’t override Managed Services port-443 blocking.
Apply the same logic for both IPv4 and IPv6 firewall rule generation paths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
source/firewall/firewall.c	Detects 443 in Managed Services blocks and gates `blockssl` rule emission accordingly (IPv4).
source/firewall/firewall_ipv6.c	Mirrors the same 443 detection and `blockssl` gating logic for IPv6.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

source/firewall/firewall.h:1278

This header now ends without closing the __FIREWALL_H__ include guard that starts near the top of the file. That will trigger an “unterminated #ifndef” preprocessor error and break the build. Add the final #endif at the end of the file (after these new declarations).

* @return None.
*
*/
void do_ssl_blocking_rules(FILE *fp, const char *chain_name);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

suriya-prem added 7 commits April 2, 2026 20:46

Update firewall.c

f832136

Update firewall_ipv6.c

e652091

Update firewall.c

479b570

Update firewall_ipv6.c

38cee92

Update firewall.c

6a3776e

Update firewall_ipv6.c

0995087

Update firewall.c

569a4dd

Copilot AI review requested due to automatic review settings April 3, 2026 11:09

suriya-prem requested review from a team as code owners April 3, 2026 11:09

Copilot started reviewing on behalf of suriya-prem April 3, 2026 11:09 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

suriya-prem added 2 commits April 3, 2026 17:05

Update firewall.c

759a423

Update firewall_ipv6.c

66a18ac

Copilot AI review requested due to automatic review settings April 3, 2026 11:36

Copilot started reviewing on behalf of suriya-prem April 3, 2026 11:37 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

Comment thread source/firewall/firewall_ipv6.c Outdated

aadhithan01 reviewed Apr 3, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

aadhithan01 reviewed Apr 3, 2026

View reviewed changes

Comment thread source/firewall/firewall_ipv6.c Outdated

Update source/firewall/firewall.c

2e293d8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 6, 2026 06:15

Update source/firewall/firewall_ipv6.c

18205b4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of suriya-prem April 6, 2026 06:16 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

Comment thread source/firewall/firewall_ipv6.c Outdated

suriya-prem added 2 commits April 6, 2026 13:22

Update firewall_ipv6.c

fa63883

Update firewall.c

2948e10

Copilot AI review requested due to automatic review settings April 6, 2026 07:53

Copilot started reviewing on behalf of suriya-prem April 6, 2026 07:54 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Comment thread source/firewall/firewall_ipv6.c Outdated

Update firewall.h

6f3a2b4

Update firewall.c

62bd5d8

Copilot AI review requested due to automatic review settings April 6, 2026 09:49

Copilot started reviewing on behalf of suriya-prem April 6, 2026 09:49 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Comment thread source/firewall/firewall.h Outdated

Comment thread source/firewall/firewall.h Outdated

suriya-prem added 2 commits April 6, 2026 15:42

Update firewall.h

2fc7904

Update firewall.h

9855690

Copilot AI review requested due to automatic review settings April 6, 2026 10:26

Copilot started reviewing on behalf of suriya-prem April 6, 2026 10:27 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

suriya-prem added 2 commits April 8, 2026 14:51

Update firewall.c

f9a5d3f

Update firewall_ipv6.c

1b5ba90

Copilot AI review requested due to automatic review settings April 8, 2026 09:28

Update firewall.c

1e49d90

Copilot started reviewing on behalf of suriya-prem April 8, 2026 09:29 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread source/firewall/firewall.c Outdated

Updated Files to have common function

775d17d

aadhithan01 requested changes Apr 15, 2026

View reviewed changes

Comment thread source/firewall/firewall_utils.c Outdated

Comment thread source/firewall/firewall_utils.c Outdated

Addressed comments

53dd717

Copilot AI review requested due to automatic review settings April 15, 2026 15:59

Copilot started reviewing on behalf of suriya-prem April 15, 2026 16:00 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread source/firewall/firewall_utils.c Outdated

Comment thread source/firewall/firewall_utils.c Outdated

Comment thread source/firewall/firewall_utils.c

Update source/firewall/firewall_utils.c

140986e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 16, 2026 06:29

Copilot started reviewing on behalf of suriya-prem April 16, 2026 06:30 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread source/firewall/firewall_utils.c Outdated

aadhithan01 and others added 2 commits April 16, 2026 21:06

Merge branch 'develop' into feature/block_https_sites

5ad66b9

Update source/firewall/firewall_utils.c

b4efd76

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 17, 2026 04:17

Copilot started reviewing on behalf of suriya-prem April 17, 2026 04:18 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread source/firewall/firewall_utils.c

Conversation

suriya-prem commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants