Skip to content

Fix for #48 (items duping upon assembly/disassembly)#365

Open
aphom wants to merge 14 commits intoryanhcode:mainfrom
aphom:main
Open

Fix for #48 (items duping upon assembly/disassembly)#365
aphom wants to merge 14 commits intoryanhcode:mainfrom
aphom:main

Conversation

@aphom
Copy link
Copy Markdown

@aphom aphom commented Apr 22, 2026

Rudimentary fix for items duping upon assembly and disassembly.

Closes #48, closes Creators-of-Aeronautics/Simulated-Project#315, closes Creators-of-Aeronautics/Simulated-Project#329, closes Creators-of-Aeronautics/Simulated-Project#94

The old blocks that were being assembled / disassembled are first temporarily replaced by barriers to prevent brittle blocks from breaking prematurely, then they are replaced by air to complete the assembly / disassembly, which fixes the issue with certain items duping.

Before the fix is applied:
create_aeronautics_before_fix_low

After the fix is applied:
create_aeronautics_after_fix_low

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2026

CLA assistant check
All committers have signed the CLA.

@ryanhcode ryanhcode self-assigned this Apr 22, 2026
@aphom
Copy link
Copy Markdown
Author

aphom commented Apr 22, 2026

There are still issues with these blocks listed below that allow placement of brittle blocks, as they also have the "wrench_pickup" tag, so they mess up the sorting because they are included in the list of brittle blocks.. so the dupe bug still happens with them. Not sure how to fix this as of right now without manually making a specific list of blocks that should be excluded from the brittle blocks list, which would probably not be feasible because of other addons' blocks.

  • Redstone Lamp, Target Block, Observer, Hopper, Pistons, Daylight Detector, Cart Assembler, Block of Industrial Iron, Block of Weathered Iron, Andesite Bars, Brass Bars, Copper Bars

From some testing it seems that these blocks mostly have issues while disassembling.

*This is no longer an issue with the new fix implementation.

aphom and others added 5 commits April 22, 2026 14:17
@aphom aphom changed the title Rudimentary fix for #48 Fix for #48 (items duping upon assembly/disassembly) Apr 23, 2026
@aphom
Copy link
Copy Markdown
Author

aphom commented Apr 23, 2026

With the new version of the fix, the issue with those select blocks that were mentioned previously no longer happens. Physics contraptions assemble and disassemble normally, without item duping.

create_aeronautics_after_fix_2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants