Feat: define objects over base fields#52
Open
kunxian-xia wants to merge 25 commits intofeat/goldilocks-spartanfrom
Open
Feat: define objects over base fields#52kunxian-xia wants to merge 25 commits intofeat/goldilocks-spartanfrom
kunxian-xia wants to merge 25 commits intofeat/goldilocks-spartanfrom
Conversation
darth-cy
force-pushed
the
feat/goldilocks-spartan
branch
from
88029e3 to
5f86ada
Compare
…roof struct." This reverts commit 4b160ca.
darth-cy
changed the base branch from
feat/goldilocks-spartan
to
feat/remove_backend_zk
darth-cy
changed the base branch from
feat/remove_backend_zk
to
feat/goldilocks-spartan
darth-cy
changed the base branch from
feat/goldilocks-spartan
to
feat/remove_backend_zk
Base automatically changed from
feat/remove_backend_zk
to
feat/goldilocks-spartan
December 10, 2024 01:23
kunxian-xia
commented
Dec 11, 2024
Comment on lines
+194
to
+196
| ops_addr: Vec<DensePolynomial<S, Ext>>, | ||
| read_ts: Vec<DensePolynomial<S, Ext>>, | ||
| audit_ts: DensePolynomial<S, Ext>, |
Collaborator
Author
There was a problem hiding this comment.
These multilinear polynomials should be defined over Base.
Comment on lines
+206
to
+207
| let mut ops_addr_vec: Vec<DensePolynomial<S, Ext>> = Vec::new(); | ||
| let mut read_ts_vec: Vec<DensePolynomial<S, Ext>> = Vec::new(); |
Collaborator
Author
There was a problem hiding this comment.
see above comments.
kunxian-xia
commented
Dec 11, 2024
| pub struct MultiSparseMatPolynomialAsDense<S: SpartanExtensionField> { | ||
| batch_size: usize, | ||
| val: Vec<DensePolynomial<S>>, | ||
| val: Vec<DensePolynomial<S, Ext>>, |
Collaborator
Author
There was a problem hiding this comment.
This should be defined over Base. It's the M[i,j] where M \in {A, B, C}.
Comment on lines
+259
to
+260
| comb_ops: DensePolynomial<S, Ext>, | ||
| comb_mem: DensePolynomial<S, Ext>, |
Collaborator
Author
There was a problem hiding this comment.
These two multilinear polynomials should also be defined over Base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.