Skip to content

fix(init): use JS template for dynamic configuration#1567

Open
sanskarajput wants to merge 1 commit intosequelize:mainfrom
sanskarajput:fix/init-dynamic-config-js-content
Open

fix(init): use JS template for dynamic configuration#1567
sanskarajput wants to merge 1 commit intosequelize:mainfrom
sanskarajput:fix/init-dynamic-config-js-content

Conversation

@sanskarajput
Copy link
Copy Markdown

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

Closes #1566

When using .sequelizerc with a .js config path, sequelize init
was generating JSON content inside the .js file instead of valid JS.

This fix checks if the config path ends with .js and generates
the correct JS template accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sequelize init writes JSON content into .js config file when using .sequelizerc

1 participant