fix(init): use JS template for dynamic configuration#1567
Open
sanskarajput wants to merge 1 commit intosequelize:mainfrom
Open
fix(init): use JS template for dynamic configuration#1567sanskarajput wants to merge 1 commit intosequelize:mainfrom
sanskarajput wants to merge 1 commit intosequelize:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testpass with this change (including linting)?Description of change
Closes #1566
When using
.sequelizercwith a.jsconfig path,sequelize initwas generating JSON content inside the
.jsfile instead of valid JS.This fix checks if the config path ends with
.jsand generatesthe correct JS template accordingly.