Skip to content

Rewrite SF Compute provider to use sfc-go#2

Open
brianlechthaler wants to merge 2 commits intosfc-brev-v2from
cursor/rewrite-sfcompute-sdk-76c3
Open

Rewrite SF Compute provider to use sfc-go#2
brianlechthaler wants to merge 2 commits intosfc-brev-v2from
cursor/rewrite-sfcompute-sdk-76c3

Conversation

@brianlechthaler
Copy link
Copy Markdown

Summary

  • replace the SF Compute provider's old nodes-go integration with the new sfc-go SDK
  • update instance creation to follow the preview resource model by managing nodes through a shared capacity + procurement pool per credential/stage/location
  • switch Brev metadata persistence from encoded node names to node tags while preserving backward compatibility for legacy names
  • add focused unit tests for tag metadata parsing, v2 status mapping, and preview-style cloud-init payload generation

Testing

  • go test ./v1/providers/sfcompute/... ./v1/...
Open in Web Open in Cursor 

Co-authored-by: Brian Lechthaler <brianlechthaler@protonmail.ch>
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 17, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  v1/providers/sfcompute/client.go  46% smaller
  v1/providers/sfcompute/instance.go  13% smaller
  v1/providers/sfcompute/instancetype.go  6% smaller
  go.mod Unsupported file format
  go.sum Unsupported file format
  v1/providers/sfcompute/instance_test.go  0% smaller
  v1/providers/sfcompute/raw_api.go  0% smaller

Co-authored-by: Brian Lechthaler <brianlechthaler@protonmail.ch>
@brianlechthaler brianlechthaler marked this pull request as ready for review April 17, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants