fix: Sub-bundles not handled in project ci#960
Closed
Philipp Schuch (Phil23) wants to merge 1 commit intomainfrom
Closed
fix: Sub-bundles not handled in project ci#960Philipp Schuch (Phil23) wants to merge 1 commit intomainfrom
Philipp Schuch (Phil23) wants to merge 1 commit intomainfrom
Conversation
Soner (shyim)
requested changes
Apr 17, 2026
| lookingForExtensionsSection := ci.Default.Section(cmd.Context(), "Looking for extensions") | ||
|
|
||
| sources := extension.FindAssetSourcesOfProject(cmd.Context(), args[0], shopCfg) | ||
| sources, err := extension.DumpAndLoadAssetSourcesOfProject(cmd.Context(), args[0], shopCfg) |
Member
There was a problem hiding this comment.
That's on purpose so, as Shopware is in a unstable state in CI as we don't have a MySQL server and plugins often break than. Is maybe just a .shopware-extension.yaml missing? See commercial plugin
There was a problem hiding this comment.
Good hint. That seems to be the issue. Closing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Other than the
project admin-buildcommand, theproject cidoes not consider the bundle dump, which leads to sub-bundles from plugins not being discovered. Corresponding assets, like JS files, are therefore not compiled.This PR adds
DumpAndLoadAssetSourcesOfProjectto theproject cicommand to implement the same behavior as theadmin-buildcommand.