Save and restore activeCubeFace and activeMipmapLevel when rendering to render target#315
Open
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Open
Save and restore activeCubeFace and activeMipmapLevel when rendering to render target#315mrxz wants to merge 1 commit intosparkjsdev:mainfrom
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SplatAccumulatorsaves and restore the current render state. However, for the render target it only recorded the target itself and not the active cube face or active mipmap level. This caused a regression in the envMap example, where the resulting envmap does not have all its faces rendered, as can be seen by the "black" reflected in the duck model.It would be nicer if
SparkRenderer.renderCubeMapcould ensure that the splats are only updated once, instead of once per cube face. That said, this bugfix would still be needed in any situation where the current render target has a non-zero cube face or mipmap level.