Skip to content

fix(loopyLoop): loop between markers when repeat-one is active#3832

Closed
3xyy wants to merge 1 commit intospicetify:mainfrom
3xyy:loopyloop-repeat-one-fix
Closed

fix(loopyLoop): loop between markers when repeat-one is active#3832
3xyy wants to merge 1 commit intospicetify:mainfrom
3xyy:loopyloop-repeat-one-fix

Conversation

@3xyy
Copy link
Copy Markdown
Contributor

@3xyy 3xyy commented Apr 24, 2026

No description provided.

Previously, reaching the ] end marker always called Player.next(),
which bypassed Spotify's repeat-one mode and advanced to the next
track. Now check getRepeat() === 2 at ] and seek back to [ instead,
so repeat-one properly loops between the custom markers.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81218ce0-b58c-4215-965f-2957de8a9af4

📥 Commits

Reviewing files that changed from the base of the PR and between 035d194 and ecc4191.

📒 Files selected for processing (1)
  • Extensions/loopyLoop.js

📝 Walkthrough

Walkthrough

The end-marker enforcement in loopyLoop.js now conditionally branches based on Spotify's repeat mode. When repeat-one is active, the script seeks to the configured start position instead of advancing to the next track, while other repeat modes preserve existing behavior.

Changes

Cohort / File(s) Summary
End-marker repeat-one handling
Extensions/loopyLoop.js
Added conditional logic to detect repeat-one mode (value 2) via Spicetify.Player.getRepeat() and perform seek-to-start instead of advancing to next track; other repeat modes retain original pending-URI + next() behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • rxri

Poem

🐰 A loop that's wise now knows to turn,
When repeat-one makes the music churn,
Back to start we gently seek,
Instead of skipping track-to-track!
~Loopy's favorite rabbit hack 🎵

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@3xyy 3xyy closed this Apr 24, 2026
@3xyy 3xyy deleted the loopyloop-repeat-one-fix branch April 24, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant